Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix-ups for macOS #318

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

barracuda156
Copy link

  1. -fobjc-arc is not a valid flag for GCC, so it must not be used with it.
  2. At least some macOS versions require sys/types.h for ssize_t.

@d99kris d99kris self-assigned this Dec 15, 2024
@d99kris
Copy link
Owner

d99kris commented Dec 29, 2024

Hi @barracuda156 - thanks for contributing!

For the change in ext/clip/CMakeLists.txt I was going to suggest to contribute it upstreams in https://github.com/dacap/clip but I see now that you already have done so, so I will likely just pull latest clip and integrate into nchat.

Similarly for the change in lib/tgchat/ext/td/tdnet/CMakeLists.txt it would be ideal if it could be done upstreams in https://github.com/tdlib/td instead, so that nchat copy of tdlib does not need to diverge too much. We currently have some changes we apply every time we update nchat in utils/tdlib-update but it would be best not to add more stuff there I feel.

Finally for the change in lib/ncutil/src/fileutil.h I think it looks fine, only minor thing is that I think we can skip the ifdef guard for non-apple platforms and just include it for all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants