xroot: handle haproxy and checksum command #7686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: ---------- When using xrootd doors behind an HAProxy w/ `xrootd.enable.proxy-protocol=true` it has been discovered that ``` xrdcp --cksum adler32:<value> <source> <destiation> ``` hangs after upload has completed and then eventually fails after a timeout. This is due to xrootd door repoting actual door address to the client. Modification: ------------- Return destination address (that is haproxy address) if `xrootd.enable.proxy-protocol=true` is set. Result: ------- ``` xrdcp --cksum adler32:<value> <source> <destiation> ``` works as expected (and likely many other similar commands) Target: trunk Request: 10.* Request: 9.2 Patch: https://rb.dcache.org/r/14338/ Acked-by: Tigran Require-book: no Require-notes: yes Signed-off-by: Dmitry Litvintsev <[email protected]> (cherry picked from commit e98ab94)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When using xrootd doors behind an HAProxy w/
xrootd.enable.proxy-protocol=trueit has been discovered thathangs after upload has completed and then eventually fails after a timeout. This is due to xrootd door repoting actual door address to the client.
Modification:
Return destination address (that is haproxy address) if
xrootd.enable.proxy-protocol=trueis set.Result:
works as expected (and likely many other similar commands)
Target: trunk
Request: 10.*
Request: 9.2
Patch: https://rb.dcache.org/r/14338/
Acked-by: Tigran
Require-book: no
Require-notes: yes
Signed-off-by: Dmitry Litvintsev [email protected]
(cherry picked from commit e98ab94)