Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SushiBeltTrackerItem properties access #14

Merged
merged 5 commits into from
May 16, 2024
Merged

Update SushiBeltTrackerItem properties access #14

merged 5 commits into from
May 16, 2024

Conversation

GeekTree0101
Copy link
Contributor

Making a custom visibleRatioCalculator, anyone cannot access SushiBeltTrackerItem useful properties.

@GeekTree0101 GeekTree0101 added the bug Something isn't working label May 13, 2024
@GeekTree0101 GeekTree0101 self-assigned this May 13, 2024
jaxtynSong
jaxtynSong approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@jaxtynSong jaxtynSong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ElonPark
ElonPark approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@ElonPark ElonPark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍👍

ppth0608
ppth0608 approved these changes May 13, 2024
View reviewed changes
Copy link

@ppth0608 ppth0608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@GeekTree0101 GeekTree0101 merged commit 058749e into develop May 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaxtynSong jaxtynSong jaxtynSong approved these changes

@ElonPark ElonPark ElonPark approved these changes

@ppth0608 ppth0608 ppth0608 approved these changes

Assignees

@GeekTree0101 GeekTree0101

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GeekTree0101 @ppth0608 @ElonPark @jaxtynSong