-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core, react): add hasZIndex
option in useStepFlow()
#567
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Open in Stackblitz • @stackflow/demo
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: 테스트에 -1,0,1만 있어서 헷갈리는데, [activity[step, step], activity] 라고 치면 [0[1, 2], 3] 인거죠? (전부 hasZIndex로 push했단 가정 하에)
@malangcat 네 맞아요 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
기능 자체는 문제없는데, (최종적으로 걷어내야 한다고 생각하는) step의 역할을 더 확장하는 게 우려되네요.
🦋 Changeset detectedLatest commit: 0c12c0d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
a4dfffb
to
5d0f7d3
Compare
No description provided.