Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core, react): add hasZIndex option in useStepFlow() #567

Merged
merged 6 commits into from
Feb 13, 2025

Conversation

tonyfromundefined
Copy link
Member

No description provided.

Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
stackflow-docs ✅ Ready (Inspect) Visit Preview Feb 13, 2025 9:58am

Copy link

pkg-pr-new bot commented Feb 4, 2025

Open in Stackblitz@stackflow/demo

yarn add https://pkg.pr.new/@stackflow/[email protected]
yarn add https://pkg.pr.new/@stackflow/[email protected]

commit: 5d0f7d3

Copy link
Contributor

@ENvironmentSet ENvironmentSet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@malangcat malangcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: 테스트에 -1,0,1만 있어서 헷갈리는데, [activity[step, step], activity] 라고 치면 [0[1, 2], 3] 인거죠? (전부 hasZIndex로 push했단 가정 하에)

@ENvironmentSet
Copy link
Contributor

@malangcat 네 맞아요

Copy link
Collaborator

@malangcat malangcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기능 자체는 문제없는데, (최종적으로 걷어내야 한다고 생각하는) step의 역할을 더 확장하는 게 우려되네요.

Copy link

changeset-bot bot commented Feb 13, 2025

🦋 Changeset detected

Latest commit: 0c12c0d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@stackflow/react Minor
@stackflow/core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tonyfromundefined tonyfromundefined merged commit 8bf74af into main Feb 13, 2025
6 of 7 checks passed
@tonyfromundefined tonyfromundefined deleted the step-has-z-index branch February 13, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants