Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move index types out of compiler pass #33

Merged
merged 1 commit into from
Sep 22, 2023
Merged

move index types out of compiler pass #33

merged 1 commit into from
Sep 22, 2023

Conversation

solverat
Copy link
Member

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? yes
Fixed tickets --

Since pimcore requires container services to determinate asset / document types, we need to move the assertion out of the compiler pass.

@solverat solverat merged commit ca66f75 into master Sep 22, 2023
3 checks passed
@solverat solverat deleted the type_selection branch September 22, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant