Update: Merge for version v1.8.0 [TECN-9190]. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Correct extension for config * Add version tag * Add dev intall to config * Correct Singer Python dependency conflict * fix indentation for pylint
* create spikes folder for discovery and add protobuff to setup * add more fields to campaign schema * Attempt at getting some kind of auto schema * Clean up, added comments to links where to look up missing classes, refactored out giant elif blocks * use refs * Add note to inspect for enum types * Add schema files for core objects * rename files to be consistent with existing integration * Change Schema folder location and write discovery for core streams * actually add schemas * Correct Primary Key for ads stream * Make Pylint happy * Delete campaigns.json * Make pylint happier Co-authored-by: dylan-stitch <[email protected]> Co-authored-by: Dan Mosora <[email protected]> Co-authored-by: Bryant Gray <[email protected]>
Co-authored-by: Bryant Gray <[email protected]>
* adding base test * adding discovery * run discovery test in circle Co-authored-by: Manoj Kumar Anand <[email protected]>
* hardcode login and customer ids for now * log better Co-authored-by: kspeer <[email protected]>
* Begin report discovery work * Add report discovery * make pylint happy and black formatting * Add login_customer_id to test config * fix shape of login_customer_id in test config * add report streams to test and fix missing metadata for report streams * Update test to use Adwords report names, update primary and replication keys * Update discovery code to discover reports * Add workaround for all caps report names * Rename BaseReport to BaseStream, Initialize core streams, Fix missing field in AD_PERFORMANCE_REPORT_FIELDS * Rename functions, add discovery for core streams * Enable tests for core streams, update names to be capitalized * Update report streams to be capitalized snake case * Update expectation to allow `"inclusion": "unsupported"` * Sync core streams (AutoIDM#10) * Remove report streams * Move report definitions to new file, change name of PlaceholderFeedItemPerformanceReport to PlaceholderFeedItemReport, changed Placeholder_Feed_Item_Report from a BaseStream to PlaceholderFeedItemReport, add sync func to BaseStream * Create resource_schema in main to pass to discover and sync, call BaseStream.sync for core streams, remove unused functions, fix whitespace * Format using black * Make pylint happy * Stop passing params that exist on `stream` * Rename `stream` to `catalog_entry` * Make pylint happier * Make pylint happy, format with black * Organize reports * Add unit test for flatten * Add unit tests for get_segments and get_attributes * Add more core streams * Make stream names lowercase * Remove attributed resources from core streams, Remove resource name, transform field names, run black * Fix attribute field exclusion bug * Display streams as plural resource names * Transform fields to google_ads field names before query, transform back to schema def * Add tests for field name transform Co-authored-by: Andy Lu <[email protected]> Co-authored-by: Bryant Gray <[email protected]> Co-authored-by: kspeer <[email protected]>
* WIP Discovery Testing (fields for accounts and campaigns) * added src code hack so tests run * added a canary sync for core streams * pylint fix * added replication test - core objects Co-authored-by: kspeer <[email protected]>
* updates to base * tap_stream_id != stream_name BUG * added start date test (WIP) Co-authored-by: kspeer <[email protected]>
* Fix metrics field exclusion bug * Enable report discovery and sync * Remove the prefix from fields names in the resource schema and json schema * Fix bug caused by shared references * Use a tuple literal * Add table-foreign-key-properties to stream metadata * Add function to create nested JSON schema for core streams * Add tests for `create_nested_resource_schema` * Refactor function to allow reuse with reports * Fix tests after refactor * Working sync for core streams * Fix field exclusion and metadata bugs * Add ReportStream class, update PK names * Remove flatten because schema is no longer flat * Fix primary key bug * Require date as a segment * Fix ads stream bugs * Add remapping for ads in report * WIP Incremental sync for report streams * Make state global * Add hash of attributes and segments as PK for report streams * Change reports to use the ReportStream class * Change adgroupperformancereport to use report stream, don't write state as often * Make pylint happy * Change fields-to-sync to tap-google-ads.api-field-names Co-authored-by: leslie vandemark [email protected] * Fix record hash and add tests for record hash * Make inclusion automatic on foreign keys * Add docstring to create_resource_schema * Change metadate fields_to_sync to tap-google-ads.api-field-names, don't look for api-field-names on record hash * Add conversion window, Don't store the whole response in memory since paging happens automatically * Enable `campaign_criteria_report` * Fix field exclusion bug where one resource has the other in its `selectable_with` list but not the other way around * Change multiple resource reports to use one resource for alpha * Change core sync to not load whole response in memory * Change query range to 1 day, Add logs, begin refactoring * Separate functionality into separate files * Remove unused functions and variables * WIP discovery refactor * Move Required Config to init * remove reports.py after rename * Remove unused import * Qa/reports 1 (AutoIDM#14) * create spikes folder for discovery and add protobuff to setup * add more fields to campaign schema * Attempt at getting some kind of auto schema * Clean up, added comments to links where to look up missing classes, refactored out giant elif blocks * use refs * Add note to inspect for enum types * WIP on handling enums * updated disco test * wip syncing report streams * Manger Segment BUG squashed * wip on canary * updated discovery and documented discrepancies within test * auto fields bug mostly squarshed * WIP canarying all streams * sync canary passing with partial coverage * Updates to dicovery, start date, and canary * start date test wip Co-authored-by: dylan-stitch <[email protected]> Co-authored-by: Dan Mosora <[email protected]> Co-authored-by: Bryant Gray <[email protected]> Co-authored-by: kspeer <[email protected]> * Use the pylint disable env var (AutoIDM#15) Co-authored-by: dylan-stitch <[email protected]> * Change single quotes to double quotes * Remove `format_field_names` We made this change to get a simple set of unit tests passing before we refactor all of this discovery code. There seems to be a bug in the current implementation of `format_field_names` * Ensure segmenting resources are accounted for in metadata * Pulled `format_field_names` into ReportStream class * Pulled `format_field_names` into BaseStream class * Refactor WIP; complete format_field_name moves in both base and report classes * Refactor WIP; move metadata creation to base and report classes * Refactor WIP: Complete discovery refactoring * Make pylint as happy as possible knowing it will never be pleased * First performance report update * Remove extra category assignment We ran tests locally and found that every `field_schema` has a category of segment already. And because we weren't setting the category for attributes and metrics as well, this code is just redundant. * disco test update, auto fields test added * Ran black * Add user_view_performance_report * Update config with parallelized jobs and steps * trust the workspace attach to persist a file * just copy env vars where needed * testing a test counter * Remove multiple-resource related code (AutoIDM#16) * Use `singer.utils.should_sync_field` to filter for selected fields * Add the user_view_performance_report to tests * Write the json schema for date fields as datetimes * Compare datetime objects instead of strings (AutoIDM#17) Co-authored-by: dylan-stitch <[email protected]> * updates to auto, disoc, start tests * Add workarounds to get tests passing * Sort excluded streams * Update user_view to user_location_performation_report * auto field test passing with workaround * Adds failing tests for metadata bugs. Add failing tests for TDL-17848 and TDL-17845 * Fix failing metadata tests Adds forced replication method and valid replication key. * Ensure transformer filters out non-selected fields * Update test expectations to allow null foreign keys * tests partial refactor for selecting streams/fields, add first report to bookmarks test * Update reports test to check each report for automatic fields * Raise exception when report only has automatic fields selected * Clean up imports * increased test coverage for start date * updates to auto fields test, simplify field selection in start date * fix automatic fields for core stream foreign keys * WIP start date test split out streams to test * Finalized start date test for Alpha * fix the parallelism 9->6 * just install required dependencies * don't count test * fix pylint with variable reference * Install pylint * Show the tap installed correctly * Revert "Show the tap installed correctly" This reverts commit 5b066f4acd97c228278417bde5ab91a6f46a21e8. * Revert "Install pylint" This reverts commit 06d196920b789fd50a67226b4c003cc4670dcecf. * Install tap-google-ads without `-e`, install dev dependencies * Bugs squashed: 17839, 17827 * Bug squashed: TDL-17840 * Failing assertions for TDL-17887 * Regroup functions for readability, rename sync_* to sync, set currently syncing in core streams * Revert to conversion_window per discussed naming conventions * Clear currently_syncing after stream completion * Fix bug TDL-17887, whitespace clean up * Fix import for create_nested_resource_schema * Remove tests for deleted functions * Update import for generate_hash * Add get_query_date, add unit tests for get_query_date * Add unit tests to circle runs * Finish refactor - call the new function name * Fix imports in unit test * Fix bug in refactor: update arg name * Remove default value in get_bookmark * Pass in a datetime string to get_query_date * Return datetime objects from get_query_date * Clean up TODO * Fix unit tests * Bookmark updates, test more streams, remove lookback from start_date * minor cleanup bookmarks test * Delete campaigns.json * Delete schema_gen_protobuf.py * Test Cleanup * comments * fix typo in disco test * fix typo in discovery test Co-authored-by: Bryant Gray <[email protected]> Co-authored-by: dylan-stitch <[email protected]> Co-authored-by: Andy Lu <[email protected]> Co-authored-by: Dan Mosora <[email protected]> Co-authored-by: kspeer <[email protected]> Co-authored-by: btowles <[email protected]> Co-authored-by: Andy Lu <[email protected]>
* Store bookmarks with only a midnight time value * Add Changelog * Cleanup bookmarks test * increase no-output timeout * address feedback in PR * Add retry logic (AutoIDM#22) * Add retry logic to the search queries Reference code https://github.com/googleads/google-ads-python/blob/7ee4523d76a159f072541146339e7cb2721a3054/examples/misc/set_custom_client_timeouts.py#L106-L125 * Add error retry and log failed query on exception * fix bookmarks test * Remove selected fields log lines * Silence google's error logging * Prevent backoff from logging google's verbose errors * Deduplicate log critical lines, remove unnecessary error logging * Whitespace clean up * Make pylint happy * Fix field exclusion Metrics and segments are the only fields that have exclusions, but those exclusions can include attributes. And because we have the logic to prefer using the root resource name when checking for `selectable_with`, we don't need to worry about filtering out resources. * Rename `adgroup` to `ad_group` and `audience_performance_report` to `ad_group_audience_performance_report`. Add `campaign_audience_performance_report` * Remove comments * Bump to v0.1.0, update changelog * Update tests to expect new streams * Remove audience_performance_report, update comments * Exclude `ad_group_audience_performance_report` from tests * Renaming streams in discovery test * Making tests happy w/ new stream names * More test stream renaming. Rename confusing Class name to be accurate. * Attempt to catch another Google Internal Error * Make attribute exclusions mutual b/c bidding_strategy * Link PR in Changelog Co-authored-by: dylan-stitch <[email protected]> Co-authored-by: kspeer <[email protected]>
* Adding mutual field exclusion tests * Updates to passing exclusion tests * Clean up * Updates from PR review Co-authored-by: btowles <[email protected]>
Co-authored-by: kspeer <[email protected]>
* Revert removal of metric compatibility removal * Whitespace cleanup
* Sync all customers for a given stream * Add logging to see when we retry requests * Update currently_syncing with customerId too. Write state as soon as we update it * Add the customerId to the bookmark keys * Add shuffle for customerId and tap_stream_id; add shuffle unit tests * Bug fix for when currently_syncing is null * Fix exception handling typeError * Fix none cases for currently_syncing * Fix currently_syncing to write a tuple we can read in later * Add get_customer_ids so we can use it in the tests * Fix manipulated_state to account for customer_ids * Update assertion for currently_syncing * Fix currently syncing assertion * Move bookmark access into Full Table assertions section Full Table doesn't need the "stream_name and customer id" key logic * Remove duplicate assertion * Revert 6db016e7ec29c2b00973b671c1efdf9451aca9c2 * Update bookmark to read stream->customer->replication_key * Update tap to write bookmarks as stream->customer->replication_key * Update manipulated state to nest stream->customer->replication_key * Run bookmark assertions for every customer * Fix dict comprehension typo * Fix conflict with main * Remove `get_state_key` again, use env var instead of hardcoded value * Add missing dependency * Move currently-syncing-null-out to the end of sync to prevent gaps * Sort selected_streams and customers to guarantee consistency across runs * Don't let the tap write (None, None) * Sort selected_streams and customers effectively * Update currently_syncing test assertions * Add sort functions for streams and customers * Update `shuffle` to handle a missing value * Update unit tests to use sort_function, add a test for shuffling streams * Add end date (AutoIDM#28) * Add optional end date, add unit tests Co-authored-by: Andy Lu <[email protected]> * Test functions can't be named run_test apparently * Rename do_thing * Extract `get_queries_from_sync` as a function * Remove unused variable * Refactor tests to be more explicit * Mock singer.utils.now to return a specific date Co-authored-by: Andy Lu <[email protected]> * add conversion_window test * fixed conversion window unittests, bug removed Co-authored-by: dylan-stitch <[email protected]> Co-authored-by: Andy Lu <[email protected]> Co-authored-by: kspeer <[email protected]>
* Bump to v0.2.0, update changelog * Add link for this PR, fix link syntax * Update changelog format
* add conversion window test * add conversion window test * wip updated tests to worka with currently syncing dev branch [skip ci] * Revert removal of metric compatibility removal (AutoIDM#29) * Revert removal of metric compatibility removal * Whitespace cleanup * Add currently syncing (AutoIDM#24) * Sync all customers for a given stream * Add logging to see when we retry requests * Update currently_syncing with customerId too. Write state as soon as we update it * Add the customerId to the bookmark keys * Add shuffle for customerId and tap_stream_id; add shuffle unit tests * Bug fix for when currently_syncing is null * Fix exception handling typeError * Fix none cases for currently_syncing * Fix currently_syncing to write a tuple we can read in later * Add get_customer_ids so we can use it in the tests * Fix manipulated_state to account for customer_ids * Update assertion for currently_syncing * Fix currently syncing assertion * Move bookmark access into Full Table assertions section Full Table doesn't need the "stream_name and customer id" key logic * Remove duplicate assertion * Revert 6db016e7ec29c2b00973b671c1efdf9451aca9c2 * Update bookmark to read stream->customer->replication_key * Update tap to write bookmarks as stream->customer->replication_key * Update manipulated state to nest stream->customer->replication_key * Run bookmark assertions for every customer * Fix dict comprehension typo * Fix conflict with main * Remove `get_state_key` again, use env var instead of hardcoded value * Add missing dependency * Move currently-syncing-null-out to the end of sync to prevent gaps * Sort selected_streams and customers to guarantee consistency across runs * Don't let the tap write (None, None) * Sort selected_streams and customers effectively * Update currently_syncing test assertions * Add sort functions for streams and customers * Update `shuffle` to handle a missing value * Update unit tests to use sort_function, add a test for shuffling streams * Add end date (AutoIDM#28) * Add optional end date, add unit tests Co-authored-by: Andy Lu <[email protected]> * Test functions can't be named run_test apparently * Rename do_thing * Extract `get_queries_from_sync` as a function * Remove unused variable * Refactor tests to be more explicit * Mock singer.utils.now to return a specific date Co-authored-by: Andy Lu <[email protected]> * add conversion_window test * fixed conversion window unittests, bug removed Co-authored-by: dylan-stitch <[email protected]> Co-authored-by: Andy Lu <[email protected]> Co-authored-by: kspeer <[email protected]> * Bump to v0.2.0, update changelog (AutoIDM#31) * Bump to v0.2.0, update changelog * Add link for this PR, fix link syntax * Update changelog format * expanded conversion window testing for error case, BUG linked * parallelism 8 -> 12 * added unittest for start date within conversion window Co-authored-by: kspeer <[email protected]> Co-authored-by: Dylan <[email protected]> Co-authored-by: dylan-stitch <[email protected]> Co-authored-by: Andy Lu <[email protected]>
* WIP expanding stream coverage * WIP canary test * WIP start date test * WIP expanding stream coverage * WIP canary test * WIP start date test * Increased start date and bookmakrks tests * descrease runtime and skipping record count check in exlcusion test * fix imports for invalid selection test * Sync all customers for a given stream * Add logging to see when we retry requests * Update currently_syncing with customerId too. Write state as soon as we update it * Add the customerId to the bookmark keys * Add shuffle for customerId and tap_stream_id; add shuffle unit tests * Bug fix for when currently_syncing is null * Fix state key to separate stream name and customer id * Fix currently_syncing to write a tuple we can read in later * Add get_customer_ids so we can use it in the tests * Fix manipulated_state to account for customer_ids * Update assertion for currently_syncing * Fix currently syncing assertion * Move bookmark access into Full Table assertions section Full Table doesn't need the "stream_name and customer id" key logic * Remove duplicate assertion * Revert 6db016e7ec29c2b00973b671c1efdf9451aca9c2 * Update bookmark to read stream->customer->replication_key * Update tap to write bookmarks as stream->customer->replication_key * Update manipulated state to nest stream->customer->replication_key * Run bookmark assertions for every customer * Fix dict comprehension typo * Qa/exclusion completion (AutoIDM#26) * Adding mutual field exclusion tests * Updates to passing exclusion tests * Clean up * Updates from PR review Co-authored-by: btowles <[email protected]> * Increased start date and bookmakrks tests * WIP expanding stream coverage * WIP canary test * WIP start date test * Added interrupted sync state lite * Start two sync approach * Scenario 1 passing interrupted sync test * Peer review changes and added stream scenario * 4 interrupted sync tests passing * cleanup persisted conflicts in exclusion tests * PR feedback addressed * bump parallelism 8 -> 14 * Review changes to interrupted sync, base, and start date tests * fix collision in test namespaces * Next round of review chagnes for interrupted state tests * Added assertion for comparing 'yet-to-be-synced' records against the full uninterrupted sync * fix print line record count Co-authored-by: kspeer <[email protected]> Co-authored-by: dylan-stitch <[email protected]> Co-authored-by: btowles <[email protected]>
* Add conversion_window validation * Consolidate conversion window tests * Enable invalid conversion window integer test Co-authored-by: Bryant Gray <[email protected]>
AutoIDM#53) * Add core LABELS streams and campaign.labels fields to relevant reports * Update test exclusions to exclude new core streams. * Update discover to include campaign_label in reports list * Update foreign_key expected metadata to include attributed resource foreign_keys * Update tests to re-include campaign_labels and labels as we now have test data.
* Handles case where state does not have currently_syncing * tap-tester test added * takeout unused imports in test Co-authored-by: kspeer <[email protected]>
* Version bump and changelog entry * Update to include PR 53. * Add PR 54 to changelog
* Set geographic_view.location_type as automatic to account for reporting discrepancies * Update Automatic Fields test happy / error paths * Update base to include automatic_keys metadata for use in tests * WIP Add Automatic Report Fields * Pass automatic_keys to BaseStream; use automatic_keys for inclusion * Fix bad field name in streams; Start updating tests * Rename function to match base.py * Add closing brace -_- * Fix tests; rename ad_group_criterion_criterion_id in automatic_keys; reorder test metadata; add campaign.id to campaign_audience_performance_report * Rename report_field_parts to split_report_field * Update transform_keys to raise ad_group_ad.ad fields * Update happy path streams_to_test to exclude streams with no data * Remove field name change for ad_performance_report stream * Accept Andy's Suggestion Co-authored-by: Andy Lu <[email protected]> * Reverting Andy's change because it affects core streams * Explicitly install grpcio-status to avoid from_call attribute errors * Update setup.py with docs explaining required but unused dep Co-authored-by: Andy Lu <[email protected]> Co-authored-by: Arthur Gorka <[email protected]>
* Remove useless function * Rename "REPORTS" to "STREAMS" for accuracy / readability
* Version bump for PRs 56 and 55 * Update to exclude ad_group_ad change for ad_performance_report
* WIP add new core streams * Set geographic_view.location_type as automatic to account for reporting discrepancies * Update Automatic Fields test happy / error paths * Update base to include automatic_keys metadata for use in tests * WIP Add Automatic Report Fields * Pass automatic_keys to BaseStream; use automatic_keys for inclusion * Fix bad field name in streams; Start updating tests * Rename function to match base.py * Add closing brace -_- * Fix tests; rename ad_group_criterion_criterion_id in automatic_keys; reorder test metadata; add campaign.id to campaign_audience_performance_report * Rename report_field_parts to split_report_field * Update transform_keys to raise ad_group_ad.ad fields * Update happy path streams_to_test to exclude streams with no data * WIP remove IPDB and try except * Fix report_definition typo and add handling for user_interest_id field * Remove field name change for ad_performance_report stream * Accept Andy's Suggestion Co-authored-by: Andy Lu <[email protected]> * Reverting Andy's change because it affects core streams * Explicitly install grpcio-status to avoid from_call attribute errors * Remove ipdb -_- * Update setup.py with docs explaining required but unused dep * WIP w/ failing tests and attributed_resource foreign_keys * WIP with failing tests; remove extraneous attributed_resoruce automatic fields * Create UserInterestStream class to handle its edge case * Add transform_keys to UserInterestStream class; start test updates * Rename obj to json_message; rename variables accordingly; fix UserInterestStream transform_keys * update auto fields test to account for compound pks * Fix campaigns typo * Remove exclusion of feed and feed items from sync canary test Co-authored-by: Andy Lu <[email protected]> Co-authored-by: Arthur Gorka <[email protected]> Co-authored-by: kspeer <[email protected]> Co-authored-by: atribed <[email protected]>
* Version bump for PRs 56 and 55 * Update to exclude ad_group_ad change for ad_performance_report * Version bump for 1.3.0 Co-authored-by: Arthur Gorka <[email protected]>
* fix slack notif for build * remove click_performance_report from tests * remove click_performance_report from sync canary test * run only streams that are untested in canary sync * just skip canaray test * put back the assert in the skipped test Co-authored-by: kspeer <[email protected]>
* Tdl 19235 handle uncaught exceptions (AutoIDM#61) * Added backoff for 5xx, 429 and ReadTimeout errors. * Resolved pylint error. * Updated comments in the unittest cases. * Updated error handling. * TDL-18749 Implement interruptible full table streams. (AutoIDM#60) * Implemented interruptible full table streams. * Resolved pylint error * Resolved error in full table sync test case. * Updated config.yml to pass cci * Updated query building logic. * Updated integration test case. * Resolved review comments. * Resolved comments. * Implemeted logic to skip the duplicate records. * Resolved unittest case error. * Resolved pylint error * Resolved integration test case error * Added empty filter param for call_details and campaign_label stream. * Added unit test cases for should_sync method. * Revert "Implemeted logic to skip the duplicate records." This reverts commit cd06e11657bd35edbaefcd7f8f12acfb938e05ec. * Added logger message for debugging purpose * Updated integration test case. * Replaced .format with f string. * Updated comment in integration test. Co-authored-by: KrishnanG <[email protected]>
Co-authored-by: KrishnanG <[email protected]>
* updated readme and added sample config * updated endpoints * add new streams * resolved PR comments * fixed a typo * added the
* Add timeout parameter to search gas.search * Increase timeout to 15 minutes for safety. * Add get_request_timeout function, add config to make_request as needed * Update on_giveup to raise specific exception text for timeoutexception class; add unit test * Make Pylint happy take 1 * Update make_request signature in unittests. * Another Unittest update * More unittest fixes for signature * Add default config param value for ease of implementation in future tests * Fix pylint dangerous-defaul-value * Fix stupid error
* Initial commit for add page limit. * Added limit parameter in sync method of ReportStream class. * Fixed issue for call_details stream. * Resolved unit test case error. * Added test cases. * Updated code comments. * Fixed keyerror issue. * Updated default query limit. * Updated pagination test case. * Modify config name to be more explicit. * Update comment for accuracy. * Update property name in base and propogate name change to tests * Exclude feed from streams_to_test because of lack of data * Committing stuff from main that should have already been in Co-authored-by: dsprayberry <[email protected]>
* Make tap-tester suite use end_date to reduce test run-time * update integration tets to account for end date usage, add a unittest * fix typo in tests * save test logs as artifacts Co-authored-by: kspeer <[email protected]>
* v11 and library bump * Trying another library version for tests * protobuf version decrease to meet google ads lib reqs
* Bump google-ads client library to the minimum package version that supports the v12 api See https://developers.google.com/google-ads/api/docs/client-libs#python for more details * Update API_VERSION * Remove fields https://developers.google.com/google-ads/api/docs/diff-tool/v12/versus-v11/diffs/common/ad_type_infos --------- Co-authored-by: Dylan Sprayberry <[email protected]>
* updated api version to V13 * updated changelog
* api version changes * removed segments.product_bidding_category_level1 * removed segments.product_bidding_category_level2,3,4 and 5 * adding again product_bidding_category_level fields * product_bidding_category_level... replaced with product_category_level..
* test on python 3.11 * bump backoff in setup * version bump and changelog update * keep on standard base image [skip ci] -----------------------------
* hanges to upgrade to v17 * bump version changes --------- Co-authored-by: “rdeshmukh15” <“[email protected]”>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.