move dagster-cloud to setup.py, remove requirements.txt #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
having both is confusing. this pr moves dagster-cloud (should it be
dagster-cloud
ordagster_cloud
??) to setup.py and gets rid of requirements.txt. note that this means in local dev, the user would install dagster-cloud (which is probably fine and maybe preferred because it includes the deploy CLI)Test plan
deployed the code location successfully -- i believe we don't need to deal with backcompat because the dockerfile does pip install conditionally based on the existence of requirements.txt and setup.py