Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move dagster-cloud to setup.py, remove requirements.txt #21

Merged

Conversation

yuhan
Copy link
Contributor

@yuhan yuhan commented Oct 6, 2022

having both is confusing. this pr moves dagster-cloud (should it be dagster-cloud or dagster_cloud??) to setup.py and gets rid of requirements.txt. note that this means in local dev, the user would install dagster-cloud (which is probably fine and maybe preferred because it includes the deploy CLI)

Test plan

~/dev/dagster-cloud-serverless-quickstart main*
demo-1006 $ dagster-cloud configure
demo-1006 $ dagster-cloud serverless deploy \
  --location-name status-quo-quickstart \
  --package-name myd_agster_project

deployed the code location successfully -- i believe we don't need to deal with backcompat because the dockerfile does pip install conditionally based on the existence of requirements.txt and setup.py

@yuhan
Copy link
Contributor Author

yuhan commented Oct 6, 2022

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

Your pull request is automatically being deployed to Dagster Cloud.

Location Status Link Updated
example_location Deploy failed Oct 07, 2022 at 06:44 AM (UTC)

@yuhan yuhan force-pushed the yuhan/10-06-move_dagster-cloud_to_setup.py_remove_requirements.txt branch from 9d53139 to 386076b Compare October 6, 2022 08:03
@shalabhc
Copy link
Contributor

shalabhc commented Oct 6, 2022

This will work for the new serverless stuff we are working on. I'm not sure if there are hard dependencies on the requirements.txt being present with the existing serverless workflows. Are you able to test it? I think this will go live as soon as it is merged, right?

@yuhan
Copy link
Contributor Author

yuhan commented Oct 6, 2022

i think it works with the existing docker build because of this check

i tested from my local (against master i think) and used the CLI to deploy this template to my cloud org.

and yea.. it will go live as long as it's merged which is not good - some relevant convo about better test set up for this template

@shalabhc
Copy link
Contributor

shalabhc commented Oct 6, 2022

I think we should switch to using dashes in the python package names so it matches pypi? eg https://pypi.org/project/dagster-cloud/ and https://pypi.org/project/dagster-aws/

@yuhan
Copy link
Contributor Author

yuhan commented Oct 17, 2022

i forgot to land this. sorry about that!

@yuhan yuhan merged commit 66fe330 into main Oct 17, 2022
@yuhan yuhan deleted the yuhan/10-06-move_dagster-cloud_to_setup.py_remove_requirements.txt branch October 17, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants