Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update project structure: remove extra layer #7

Merged
merged 1 commit into from
Aug 8, 2022
Merged

update project structure: remove extra layer #7

merged 1 commit into from
Aug 8, 2022

Conversation

yuhan
Copy link
Contributor

@yuhan yuhan commented Aug 8, 2022 •
edited
Loading

  1. get rid of extra folder layer
  2. remove dagit and pytest from setup.py
  3. add relative reference in requirements.txt because we're enabling it back

this should work once dagster-io/dagster-cloud-action#21 is released

@github-actions
Copy link

github-actions bot commented Aug 8, 2022 •
edited
Loading

Your pull request is automatically being deployed to Dagster Cloud.

Location Status Link Updated
example_location View in Cloud Aug 08, 2022 at 07:59 PM (UTC)

@yuhan yuhan requested review from prha and benpankow August 8, 2022 18:50
@yuhan yuhan marked this pull request as ready for review August 8, 2022 18:50
benpankow
benpankow approved these changes Aug 8, 2022
View reviewed changes
Copy link
Member

@benpankow benpankow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat

@yuhan yuhan merged commit c192acb into main Aug 8, 2022
@yuhan yuhan deleted the yuhan/update-structure branch August 8, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prha prha prha approved these changes

@benpankow benpankow benpankow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuhan @prha @benpankow