Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include int steps #41

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dehume
Copy link

@dehume dehume commented Jan 8, 2025

Include the different iterations of the final project to make it easier to take screenshots for lessons before the final completed project.

@dehume dehume requested a review from cmpadden January 8, 2025 21:29
)

# defs = Definitions(
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also put all these different Definitions behind an env variable or something. Trying to think of how to make this more elegant.

@cmpadden
Copy link
Collaborator

cmpadden commented Jan 9, 2025

Include the different iterations of the final project to make it easier to take screenshots for lessons before the final completed project.

This repo is provided as an example completed project in the course. Would that be a problem if we make these changes?

docs/dagster-university/pages/dagster-essentials/lesson-1/project-preview.md
18:If you get stuck or want to jump ahead, check out the [finished project here on GitHub](https://github.com/dagster-io/project-dagster-university).

docs/content/concepts/assets/asset-selection-syntax.mdx
129:To demonstrate how to use the asset selection syntax, we'll use the following asset graph from the [Dagster University Essentials project](https://github.com/dagster-io/project-dagster-university):

Maybe we would need to update the course content with an explanation, or improve the readme?

@dehume dehume marked this pull request as draft January 9, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants