Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAG validation with JSON schema in YAML editor #652

Closed
yohamta opened this issue Aug 8, 2024 · 4 comments
Closed

DAG validation with JSON schema in YAML editor #652

yohamta opened this issue Aug 8, 2024 · 4 comments
Assignees
Labels
enhancement New feature to be implemented someday
Milestone

Comments

@yohamta
Copy link
Collaborator

yohamta commented Aug 8, 2024

Overview
Add the JSON schema-based validation to the DAG(YAML) editor.

JSON schema
The schema file is available at:
https://raw.githubusercontent.com/daguflow/dagu/main/schemas/dag.schema.json

Implementation
Configure react-monaco-editor to use the provided JSON schema file. The component to modify is here.

@yohamta yohamta added good first issue Good for newcomers enhancement New feature to be implemented labels Aug 8, 2024
@vhespanha
Copy link
Contributor

I'd like to take a look at this one, can you assign?

@vhespanha
Copy link
Contributor

Opened a draft PR, if the approach I took for the implementation seems correct, I can further enhance it.

PR #659

@yohamta yohamta added someday and removed good first issue Good for newcomers labels Oct 2, 2024
@arky
Copy link
Contributor

arky commented Feb 1, 2025

@vhespanha Any updates on the draft PR?

@yohamta
Copy link
Collaborator Author

yohamta commented Feb 1, 2025

Thank you for the reminder! The PR has been merged and this feature has been successfully implemented. @vhespanha, I appreciate your great contribution!

@yohamta yohamta closed this as completed Feb 1, 2025
@yohamta yohamta added this to the v1.16.1 milestone Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature to be implemented someday
Projects
None yet
Development

No branches or pull requests

3 participants