-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate DAG schema on Monaco #659
Conversation
Hi @vhespanha, thank you so much for your fantastic work and excellent suggestions! Really appreciate it, I see that this is a hard issue to handle. Regarding Schema and Definition Updates: Regarding Monaco Editor Integration: Regarding Error Handling: I did try to test the changes on my end, but it seems the schema validation isn't triggering in my environment. This could potentially be an issue on my side. I'm curious - how is it functioning in your development environment? Could you share some details or screenshots about how you're seeing it work? Once again, thank you for your hard work! |
@vhespanha @yohamta Any updates, were you able to replicate and fix the issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀🚀🚀 Thank you so much for adding autocompletion and error display to the DAG editor. It's now much more useful! Sorry it took me so long to review and merge.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #659 +/- ##
=======================================
Coverage 55.55% 55.55%
=======================================
Files 73 73
Lines 7905 7905
=======================================
Hits 4392 4392
Misses 3134 3134
Partials 379 379 Continue to review full report in Codecov by Sentry.
|
Brilliant! Thank you so much for your contribution @vhespanha |
This PR implements DAG schema validation in the Monaco Editor, like suggested here: issue #652
Changes
Schema and Definition Updates
definition
struct and JSON schema to accept both array and string representations of theParams
field.Monaco Editor Integration
Error Handling
Next steps
The current implementation is functional but i'm considering it a draft since the approach of modifying the JSON schema to handle dual
Params
representation probably needs review, I'm willing to work on better diagnostics if all is right with the current approach.