Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#700] Add Page Limit Input and Improve Case-Insensitive DAG Search #702

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

yohamta
Copy link
Collaborator

@yohamta yohamta commented Nov 8, 2024

This PR addresses #700 by improving the UI

  • Page Limit Input: Added a text box for setting the page limit
  • Case-Insensitive Search: Updated the DAG name search to be case-insensitive

@yohamta yohamta merged commit 7582f5f into main Nov 8, 2024
5 checks passed
@yohamta yohamta deleted the page-limit branch November 8, 2024 12:10
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 62.03%. Comparing base (6801654) to head (e690a19).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/persistence/local/dag_store.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #702      +/-   ##
==========================================
+ Coverage   61.97%   62.03%   +0.05%     
==========================================
  Files          53       53              
  Lines        5228     5228              
==========================================
+ Hits         3240     3243       +3     
+ Misses       1734     1732       -2     
+ Partials      254      253       -1     
Files with missing lines Coverage Δ
internal/persistence/local/dag_store.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6801654...e690a19. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant