Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug when using the CRON_TZ= cron expression #707

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

jonnochoo
Copy link
Contributor

@jonnochoo jonnochoo commented Nov 11, 2024

Related to #706, when using the CRON_Z in an expression

CRON_TZ=Asia/Tokyo 0 6 * * *

The /dags page doesn't load, see below
image

The fixed version

image

@jonnochoo jonnochoo marked this pull request as ready for review November 11, 2024 10:39
@yohamta
Copy link
Collaborator

yohamta commented Nov 12, 2024

Looking great! Thank you for the amazing fix!

@yohamta yohamta merged commit 855e75d into dagu-org:main Nov 12, 2024
7 checks passed
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.97%. Comparing base (8dc577e) to head (a2cc200).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #707   +/-   ##
=======================================
  Coverage   61.97%   61.97%           
=======================================
  Files          53       53           
  Lines        5228     5228           
=======================================
  Hits         3240     3240           
  Misses       1734     1734           
  Partials      254      254           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dc577e...a2cc200. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants