Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

primitive http auth workaround #149

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

mexican75
Copy link

No description provided.

@asciidisco
Copy link
Member

Having this method is better than having none.

The thing is, that this is not cross browser compatible (I can live with that for now). Firefox for example (which is broken atm. anyway) can not deal with credentials given via URL. Which is correct, because it is not part of any web standard.
This must be noted in the docblock section, so that it will find it´s way into the automatically generated API doc page (plus, the docBlock needs an @api annotation).

Please also see the comments I´ve made inline in your commit.
If that gets fixed, I´m happy to get it in.

@asciidisco
Copy link
Member

Any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants