Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty fields #33

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add empty fields #33

wants to merge 1 commit into from

Conversation

phylor
Copy link

@phylor phylor commented Jul 30, 2024

Preliminary version to add blank fields to the QR bill.

qr_bill_empty

I already post this here for others to give feedback. I'd like to first test it in reality though.

Todos

  • Currency/amount in the payment part is positioned a bit low. Maybe position it at the same height as the one in the receipt section. However, this is dynamic, e.g. if we don't have a reference.
  • I believe there's too little space for the "acceptance point". Maybe we have to get rid of the creditor street in the receipt section (check spec if it defines the address there).
  • Layout uses flex, which might be an issue if people still use wkhtmltopdf (as the QT backend doesn't know flex yet), maybe change to use tables instead?
  • Add a test for the QR payload

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant