Skip to content

Commit

Permalink
add the view_grades to routes and controller
Browse files Browse the repository at this point in the history
  • Loading branch information
chuyaguo committed Sep 14, 2014
1 parent 9b0209b commit 5252039
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
3 changes: 3 additions & 0 deletions app/controllers/static_pages_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,7 @@ def teacher_dashboard

def petitions
end

def view_grades
end
end
2 changes: 2 additions & 0 deletions config/routes.rb
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,7 @@
get '/teacher_dashboard', to: 'static_pages#teacher_dashboard'
get '/petitions', to: 'static_pages#petitions'
get '/quiz', to: 'static_pages#quiz'
get '/view_grades', to: 'static_pages#view_grades'

devise_for :users
end

1 comment on commit 5252039

@rgpass
Copy link
Collaborator

@rgpass rgpass commented on 5252039 Sep 14, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's OK to combine this stuff into the previous commit. It's best to commit when you get that feeling of "I just did something that is complete and useful."

For this example, having the view and CSS done in your previous commit doesn't meet the requirement -- we can't access the page because there was no route.

If it was an accident, that's totally cool. I do it from time to time still. :) If this was a professional-grade app, we would have tests and it would've been clear that this wasn't working.

Please sign in to comment.