-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
add the view_grades to routes and controller
- Loading branch information
Showing
2 changed files
with
5 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,4 +37,7 @@ def teacher_dashboard | |
|
||
def petitions | ||
end | ||
|
||
def view_grades | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5252039
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's OK to combine this stuff into the previous commit. It's best to commit when you get that feeling of "I just did something that is complete and useful."
For this example, having the view and CSS done in your previous commit doesn't meet the requirement -- we can't access the page because there was no route.
If it was an accident, that's totally cool. I do it from time to time still. :) If this was a professional-grade app, we would have tests and it would've been clear that this wasn't working.