Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design doc - Publish Dandisets that contain Zarr archives #1833
Design doc - Publish Dandisets that contain Zarr archives #1833
Changes from 11 commits
e71ee11
c0c9d66
dd40a75
2987b81
aa684fa
fc15230
b7d88ad
95bb260
9acf245
02b5dbc
acb1367
7dcae93
cfe20a2
881513e
a138173
6b84ed0
2faa5b8
b062af1
22d014c
31af71d
57eaa62
41d9449
f2be2dd
50163a2
75977f6
585756c
58ad723
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating to use more accurate domain language (there isn't such a thing as a "blob asset", and the word "version" has a specific meaning in the context of DANDI).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Essentially, we disallow publishing of Zarr-containing Dandisets because we don't want to create copies of Zarrs if and when they are updated, and we're seeking a design that would allow us to do so. You might be able to condense this paragraph down to express that more directly; the sentence in the middle ("this design means...") seems a bit out of place in particular.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would add that there are a two requirements.
for implementation:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This step seems out of place in the use case description. We can already do this part (update a Zarr that is in a draft version), and the important novelty is in step 3 and beyond.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reordered steps 2 and 3, which would reflect functionality that is currently not in place (i.e. publishing a Dandiset with a Zarr archive and subsequently updating the
Draft
version). Please let me know if I misunderstood your comment.