Improve file browser view action icons #1846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 31, 2024
Merged
waxlamp
dismissed
marySalvi’s stale review
Need a new review on subsequent changes
yarikoptic
approved these changes
Feb 9, 2024
marySalvi
approved these changes
Feb 9, 2024
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the presentation of the file browser view icons:
The open in app icon makes more sense for what that button does. And the explicit dropdown uses standard language for "open an external program", and makes the presence of those integrations more discoverable.
This was inspired by discussions on #1666.
Depends on #1845.
(attn: @magland)