Fix display of embargoed dandiset error page in GUI #2073
Merged
+27
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjnesbitt
added
patch
jjnesbitt
commented
Nov 11, 2024
| const data = await dandiRest.specificVersion(identifier, sanitizedVersion); | ||
| this.dandiset = data; | ||
| } catch (err) { | ||
| if (axios.isAxiosError(err) && err.response && err.response.status < 500) { | ||
| this.dandiset = null; | ||
|
|
||
| if (isUnauthenticatedOrForbidden(err)) { | ||
| this.meta.dandisetExistsAndEmbargoed = true; |
There was a problem hiding this comment.
@mvandenburgh I opted for this approach as functions like fetchDandiset are used in several other places in the client code base, and I didn't want to adversely affect behavior somewhere else by making a breaking change.
mvandenburgh
approved these changes
Nov 13, 2024
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1350
Follow on to #2060
It turns out the change I made to display "access denied" to embargoed dandisets didn't properly handle all cases of that access. This led to the display of "Dandiset does not exist" on dandisets that did exist, but were embargoed.