Skip to content

Commit

Permalink
Fix typo in new udev rule.
Browse files Browse the repository at this point in the history
As pointed out by Peter Rajnoha, the correct usage in udev is
TEST=="file", not TEST="file".

Also improve a related comment which was a bit informal.

Reported-by: Peter Rajnoha <[email protected]>
Fixes: cd6cbb0 ("Create: tell udev md device is not ready when first created.")
Signed-off-by: NeilBrown <[email protected]>
Signed-off-by: Jes Sorensen <[email protected]>
  • Loading branch information
NeilBrown authored and Jes Sorensen committed May 5, 2017
1 parent 9e04ac1 commit dd180cb
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib.c
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ char *fd2devnm(int fd)

/* When we create a new array, we don't want the content to
* be immediately examined by udev - it is probably meaningless.
* So create /run/mdadm/creating-FOO and expect that a udev
* So create /run/mdadm/creating-mdXXX and expect that a udev
* rule will noticed this and act accordingly.
*/
static char block_path[] = "/run/mdadm/creating-%s";
Expand Down
2 changes: 1 addition & 1 deletion udev-md-raid-creating.rules
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@
# the array is not "ready" and we should make sure the
# content is ignored.

KERNEL=="md*", TEST="/run/mdadm/creating-$kernel", ENV{SYSTEMD_READY}="0"
KERNEL=="md*", TEST=="/run/mdadm/creating-$kernel", ENV{SYSTEMD_READY}="0"

0 comments on commit dd180cb

Please sign in to comment.