Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'combobox-selected' class before triggering change events. #114

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jzamanski
Copy link

Allows change event handler to call combobox('toggle') to clear the combobox.

Allows change event handler to call combobox('toggle') to clear the combobox.
@jzamanski
Copy link
Author

Baby's first pull request. Sort of just wanted to see how PR's work. In any case, I'm binding to the change event on the source, 'consuming' the selected element, and then want to clear/reset the combobox. Since the 'combobox-selected' class is being added after the change event is fired, there's no clean way to clear/reset the combobox besides manually removing the class from the container. This was my attempt to fix that / make it do what I wanted.

@thephw thephw self-assigned this May 13, 2014
@thephw thephw added this to the 2.0 Release milestone May 13, 2014
@thephw
Copy link
Collaborator

thephw commented May 13, 2014

I think this will likely get deferred to the 2.0 release. Going to work to add and document publicly accessible events to allow people to customize the functionality similar to other bootstrap control at different points in the workflow.

@thephw thephw modified the milestone: 2.0 Release May 13, 2014
@thephw thephw removed their assignment Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants