Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support netstandard2.0 in WorkflowCore.Persistence.EntityFramework #1041 #1057

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support netstandard2.0 in WorkflowCore.Persistence.EntityFramework #1041 #1057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions ...s/WorkflowCore.Persistence.EntityFramework/Services/EntityFrameworkPersistenceProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,16 +391,18 @@ public async Task ProcessCommands(DateTimeOffset asOf, Func<ScheduledCommand, Ta
{
var cursor = db.Set<PersistedScheduledCommand>()
.Where(x => x.ExecuteTime < asOf.UtcDateTime.Ticks)
.AsAsyncEnumerable();
.AsEnumerable();

await foreach (var command in cursor)
foreach (var command in cursor)
{
try
{
await action(command.ToScheduledCommand());
using var db2 = ConstructDbContext();
db2.Set<PersistedScheduledCommand>().Remove(command);
await db2.SaveChangesAsync();
using (var db2 = ConstructDbContext())
{
db2.Set<PersistedScheduledCommand>().Remove(command);
await db2.SaveChangesAsync();
}
}
catch (Exception)
{
Expand Down
4 changes: 2 additions & 2 deletions .../WorkflowCore.Persistence.EntityFramework/WorkflowCore.Persistence.EntityFramework.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<PropertyGroup>
<AssemblyTitle>Workflow Core EntityFramework Core Persistence Provider</AssemblyTitle>
<Authors>Daniel Gerlag</Authors>
<TargetFrameworks>netstandard2.1;net6.0</TargetFrameworks>
<TargetFrameworks>netstandard2.0;net6.0</TargetFrameworks>
<AssemblyName>WorkflowCore.Persistence.EntityFramework</AssemblyName>
<PackageId>WorkflowCore.Persistence.EntityFramework</PackageId>
<PackageTags>workflow;.NET;Core;state machine;WorkflowCore;EntityFramework;EntityFrameworkCore</PackageTags>
Expand All @@ -25,7 +25,7 @@
<PackageReference Include="Microsoft.EntityFrameworkCore.Relational" Version="6.0.3" />
</ItemGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'netstandard2.1' ">
<ItemGroup Condition=" '$(TargetFramework)' == 'netstandard2.0' ">
<PackageReference Include="Microsoft.EntityFrameworkCore" Version="3.1.2" />
<PackageReference Include="Microsoft.EntityFrameworkCore.Relational" Version="3.1.2" />
</ItemGroup>
Expand Down