Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition on stop #1081

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Commits on Aug 12, 2023

  1. Add test to reproduce race condition

    If the host is stopped as soon as WorkflowCompleted LifeCycleEvent is
    raised, some persistence providers cannot persist the 'Completed' state
    in time.
    mamidenn committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    cfa5c2a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    59cca73 View commit details
    Browse the repository at this point in the history
  3. Prevent information loss on host shutdown

    Do not pass global CancellationToken to persistence operations on host
    shutdown. This way it is ensured that persistence operations are not
    cancelled.
    mamidenn committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    f150cd4 View commit details
    Browse the repository at this point in the history