RedisProvider - Remove the actual event record if we're tidying up after ourselves. #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the actual event record if we're tidying up after ourselves.
Adding in logic to CreateEvent Method
ChrisBertrand
changed the title
|
@danielgerlag Would be great to get feedback on this when you're next free. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Following the _removeComplete logic on PersistWorkflow, also remove events if this is set.
Describe your implementation or design
Followed the same logic from the PersistWorkflow method.
Tests
Tested locally.
Breaking change
No. There are no changes to the method signature or interface.
Additional context
This is really useful in the Redis provider as there is no cleanup functionality available, finding the right keys within the events hash key is rather difficult, having it as part of the main logic would simplify this.