Rework drag and drop in tests #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into development
…into development # Conflicts fixed: # src/asammdf/gui/widgets/plot.py # test/asammdf/gui/test_base.py # test/asammdf/gui/widgets/test_PlotWidget_ContextMenu.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems that in newer versions of
PySide, drag and drop operations used for tests are not working anymore.After some digging in
Qt, it seems thatexecmethod fromQDragobject is a blocking method for Windows and non-blocking on Linux only if there is no payload (no mime data).Cloning
eventthat is provided as parameter for drag and drop functionalities is not possible:eventand simulate thatsourcemethod call will return the source widget that we want, it will work only for python implementationeventis forwarded withsuper), the framework will read thesourceby it own and will bypass the mock simulationsourceof event.The proposed implementation use
win32apiandpyautoguifor Windows and Linux platforms and will physically move the mouse cursor.Note: Even if
pyautoguican be used for both platforms Windows and Linux, I choose to use thewin32apibecause it significantly faster.Timings present in implementation were fine tuned and may impact test results if there are changed.