-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: set log level to error in benchmarks to reduce log noise #26
Conversation
WalkthroughThe changes introduce a new constant, Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
CodSpeed Performance ReportMerging #26 will degrade performances by 21.95%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
=======================================
Coverage 83.73% 83.73%
=======================================
Files 7 7
Lines 1168 1168
Branches 269 269
=======================================
Hits 978 978
Misses 190 190 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- packages/beasties/test/beasties.bench.ts (8 hunks)
🔇 Additional comments (1)
packages/beasties/test/beasties.bench.ts (1)
20-20
: LGTM! Consistent application of log level configuration across all test cases.
The changes effectively reduce log noise in benchmarks by setting logLevel: 'error'
consistently across all test cases. This is a good practice for benchmark tests where we want to focus on performance metrics rather than debug output.
Also applies to: 50-50, 60-60, 86-86, 111-111, 136-136, 160-160, 172-172
37af9c6
to
63e3148
Compare
Summary by CodeRabbit
logLevel
property set to'error'
in theBeasties
constructor.DEFAULT_BEASTIES_CONFIG
, to streamline configuration across test cases.