Skip to content
This repository has been archived by the owner on Sep 17, 2023. It is now read-only.

Resurrect search #195

Merged
merged 3 commits into from
Aug 20, 2020
Merged

Conversation

iojancode
Copy link
Contributor

This PR resurrect Lucene Search. All code was ready, it was just remove comments and test.

I had to use ibmcom/couchdb3 docker image for two main reasons:

  1. CouchDB official images are not ready yet with clouseau, but this feature is almost ready [Feature Request] Provide Image with Clouseau / Fulltext Search apache/couchdb-docker#8
  2. Lucene Search is available since couchdb3 https://docs.couchdb.org/en/stable/ddocs/search.html

Copy link
Owner

@danielwertheim danielwertheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks good to me apart from that the "offical" CouchDB account at Docker now supports 3.1 and that it should be used, right?

@@ -16,7 +16,7 @@ pr: none
resources:
containers:
- container: couchdb
image: couchdb:2.3.1
image: ibmcom/couchdb3:3.1.0
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The public one now supports 3.1

@@ -20,7 +20,7 @@ pr:
resources:
containers:
- container: couchdb
image: couchdb:2.3.1
image: ibmcom/couchdb3:3.1.0
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The public one now supports 3.1

@@ -1,7 +1,7 @@
version: '3'
services:
couchdb:
image: "couchdb:2.3.1"
image: "ibmcom/couchdb3:3.1.0"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The public one now supports 3.1

@iojancode
Copy link
Contributor Author

iojancode commented Aug 16, 2020

Thanks for taking the time to review this.

Yes, the public one now supports 3.1 but not search, so unit and integration search tests fail. Official image supporting search is going to be named couchdb:3.1.0-ubi-clouseau, ready at https://github.com/apache/couchdb-docker/blob/master/3.1.0-ubi-clouseau/Dockerfile, but it has not been built and published to docker registry yet, so that's why I had to use ibmcom image.

@danielwertheim danielwertheim merged commit d02c495 into danielwertheim:master Aug 20, 2020
@danielwertheim danielwertheim linked an issue Aug 20, 2020 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lucene Search
2 participants