-
Notifications
You must be signed in to change notification settings - Fork 70
Resurrect search #195
Resurrect search #195
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Looks good to me apart from that the "offical" CouchDB account at Docker now supports 3.1 and that it should be used, right?
@@ -16,7 +16,7 @@ pr: none | |||
resources: | |||
containers: | |||
- container: couchdb | |||
image: couchdb:2.3.1 | |||
image: ibmcom/couchdb3:3.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The public one now supports 3.1
@@ -20,7 +20,7 @@ pr: | |||
resources: | |||
containers: | |||
- container: couchdb | |||
image: couchdb:2.3.1 | |||
image: ibmcom/couchdb3:3.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The public one now supports 3.1
@@ -1,7 +1,7 @@ | |||
version: '3' | |||
services: | |||
couchdb: | |||
image: "couchdb:2.3.1" | |||
image: "ibmcom/couchdb3:3.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The public one now supports 3.1
Thanks for taking the time to review this. Yes, the public one now supports 3.1 but not search, so unit and integration search tests fail. Official image supporting search is going to be named |
This PR resurrect Lucene Search. All code was ready, it was just remove comments and test.
I had to use ibmcom/couchdb3 docker image for two main reasons: