Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initialization state diff #57

Closed

Conversation

patsissons
Copy link

Community Note

Adding some constraints to the initialization block

  • ip configuration is now only added if there are any ip's defined
  • default data file id is now only added if initialization is non-empty

I was running into this with a dynamic initialization block. When the block was not being created i would see an empty initialization diff being added on every apply.

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

relates to #30 (and possibly resolves it)

Release note for CHANGELOG:

BUG FIX: initialization should no longer add an empty block on plan

@patsissons patsissons changed the title fixing initialization state diff Fix initialization state diff Dec 13, 2020
@danitso-dp danitso-dp mentioned this pull request Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant