Unified hires block blitter #2823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When @eschnett introduced the
4x2blitter in #2820, i asked him to unify it with the existingBRAILLEblitter. This was foolish--as @PhMajerus points out in #2669, there are really two kinds of pseudopixel semigraphcis, and octants are blocky whereas braille is separated (I've not used his term "mosaics", as that is already used for another concept in Notcurses). Redo the octblitter in a blocky style, and unite it with the existing sexblitter ashires_blitter(). Eliminate a large constant array from sexblitter by using the permutation table as a key into the transegcs.