Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumped simplecpp #6333

Merged
merged 1 commit into from
Apr 24, 2024
Merged

bumped simplecpp #6333

merged 1 commit into from
Apr 24, 2024

Conversation

firewave
Copy link
Collaborator

No description provided.

@@ -20,13 +20,13 @@
#include <cstring>
#include <ctime>
#include <exception>
#include <fstream>
#include <fstream> // IWYU pragma: keep
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes were missing upstream because I accidentally did them here in #5673. Addressed via danmar/simplecpp#330.

@firewave firewave merged commit f7949e7 into danmar:main Apr 24, 2024
64 checks passed
@firewave firewave deleted the simplecpp-bump branch April 24, 2024 17:16
@danmar
Copy link
Owner

danmar commented Apr 24, 2024

@firewave I would like to have more controlled simplecpp version in cppcheck. Unless you really must as a quick hack, do not just bump latest HEAD of simplecpp. We make a simplecpp release and bump that to cppcheck. If you really must bump as a quick hack sometime .. well then I think we should asap make a proper simplecpp release and copy that to cppcheck.

@firewave
Copy link
Collaborator Author

I wasn't aware of that. I thought it was fine because the changes were already approved upstream. Sorry about that.

Since we were out-of-sync anyways we should merge that PR upstream, make a release and bump it again and then we are fine again.

@danmar
Copy link
Owner

danmar commented Apr 25, 2024

I wasn't aware of that

sure, no problem. as you say we can make a release and bump again then we are fine again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants