Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Snap Supportu #351

Merged
merged 1 commit into from
Jan 9, 2024

Commits on Jan 9, 2024

  1. Restore Snap Supportu

    Create new cmake file and alter snapcraft.yaml to build snap builds once more. Due to core22
    not supporting qmake yet [1] and Qt not continuing to support qmake[2], this commit moves
    Packet Sender snap builds to cmake. In order to not mess with Debian builds (Which use
    the existing CMakeLists.txt), a new CMakeLists.txt has been added under a snap directory
    
    The alterations were generated by using qmake2cmake [3] on the .pro file for snap builds,
    and then merged under if statements for the existing CMakeLists.txt. I did have to comment out
    the git sha generation and add that back manually for the tool to work, as well as specify source root manually.
    
    [1] https://forum.snapcraft.io/t/core22-qmake-plugin-support/35026
    [2] https://www.qt.io/blog/2019/08/07/technical-vision-qt-6
    [3] https://code.qt.io/cgit/qt/qmake2cmake.git/about/
    patviafore-kudzera committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    ad87673 View commit details
    Browse the repository at this point in the history