Minification improvements #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
low hanging fruit only 'this' => 'self' 'window' => '_window' 'document' => '_document' a few var declarations moved to be next to one another Minified size reduced by 6%
Further squash document references
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Low hanging fruit only
this=>selfwindow=>_windowdocument=>_documentMoved a few var declarations to be next to one another
Minified size reduced by 7%
NOTE: While a version field has been added to the javascript file, I did not adjust the version tag. I figure that should be handled by the maintainer.
NOTE: A version number was not added to the CSS file as it has not been modified since the initial commit.