Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"2.214844" is considered a date #939

Closed
danvk opened this issue Jul 27, 2018 · 1 comment
Closed

"2.214844" is considered a date #939

danvk opened this issue Jul 27, 2018 · 1 comment
Labels
bug

Comments

@danvk
Copy link
Owner

danvk commented Jul 27, 2018

It passes the check here:

dygraphs/src/dygraph.js

Line 2611 in da2a028

} else if (str.length == 8 && str > '19700101' && str < '20371231') {

See https://stackoverflow.com/questions/51561581/dygraph-x-y-plot-with-floating-points-for-x-axis-values

Yet another reason to eliminate support for the YYYYMMDD syntax…
@danvk danvk added the bug label Jul 27, 2018
@danvk danvk mentioned this issue Feb 18, 2020
Merged
@danvk
Copy link
Owner Author

danvk commented May 11, 2023

This was fixed by #985

@danvk danvk closed this as completed May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danvk