Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #984 (Couldn't parse 20035000 as a date) #985

Merged
merged 2 commits into from
Feb 20, 2020

Conversation

lmizinski
Copy link
Collaborator

@lmizinski lmizinski commented Feb 18, 2020

Fixes problem described in #984

Date format 20035000 is problematic, because it causes error:

Couldn't parse 20035000 as a date
...
Couldn't parse 20251000 as a date

This format is problematic, because it causes error:

Couldn't parse 20035000 as a date
...
Couldn't parse 20251000 as a date

There should be parser added, that will support this format (20251000)
example data
data: "dist	sum↵20033000	49↵20034000	48↵20035000	48↵20036000"
@coveralls
Copy link

coveralls commented Feb 18, 2020

Coverage Status

Coverage increased (+0.02%) to 90.195% when pulling 06e8ac8 on lmizinski:master into 27cee3f on danvk:master.

@danvk
Copy link
Owner

danvk commented Feb 18, 2020

See also #939. Please add a test to cover this.

@lmizinski lmizinski merged commit e9155b2 into danvk:master Feb 20, 2020
@lmizinski
Copy link
Collaborator Author

lmizinski commented Feb 20, 2020

Thank you for adding me as contributor. I fixed the problem and merged it to master.

I had hard time running tests on Windows (docs on testing are little bit outdated), but I was able to figure it out using Travis log included in pull request.

I had to change locally part of package.json to

"scripts": {
    "build": "bash ./scripts/build.sh",
    "coverage": "bash ./scripts/generate-coverage.sh",
    "watch": "bash ./scripts/watch.sh",
    "build-tests": "bash ./scripts/build-tests.sh",
    "test": "bash ./scripts/run-tests.sh",
    "tests-ok": "bash ./scripts/check-no-only.sh"
  },

and then commands from Travis started working

npm run build-tests
npm run test

@leeoniya
Copy link

@lmizinski

I had hard time running tests on Windows

i made a bunch of changes to get tests passing on windows as part of #948.

feel free to pick up that PR, too 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants