Skip to content

Commit

Permalink
Drop milstein, extended-grid coders and address field (#168)
Browse files Browse the repository at this point in the history
* remove old coders!

* drop address field

* data update

* update test logs

* update locations for site
  • Loading branch information
danvk authored Nov 13, 2024
1 parent 4888797 commit 8a1a26d
Show file tree
Hide file tree
Showing 18 changed files with 41,568 additions and 41,888 deletions.
82,926 changes: 41,463 additions & 41,463 deletions data/images.ndjson

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion data/lat-lon-to-ids.json

Large diffs are not rendered by default.

Binary file modified geocache.tgz
Binary file not shown.
205 changes: 0 additions & 205 deletions oldnyc/geocode/coders/extended_grid.py

This file was deleted.

18 changes: 0 additions & 18 deletions oldnyc/geocode/coders/extended_grid_test.py

This file was deleted.

3 changes: 1 addition & 2 deletions oldnyc/geocode/coders/gpt.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
from oldnyc.geocode import grid
from oldnyc.geocode.boroughs import guess_borough, point_to_borough
from oldnyc.geocode.coders.coder_utils import get_lat_lng_from_geocode
from oldnyc.geocode.coders.extended_grid import parse_street_ave
from oldnyc.geocode.geocode_types import Coder, Locatable
from oldnyc.geocode.geogpt.generate_batch import GptResponse
from oldnyc.item import Item
Expand Down Expand Up @@ -80,7 +79,7 @@ def getLatLonFromLocatable(self, r, data):
if boro != "Manhattan":
return None
try:
avenue, street = parse_street_ave(str1, str2)
avenue, street = grid.parse_street_ave(str1, str2)
latlon = grid.code(avenue, street)
if latlon:
self.n_grid += 1
Expand Down
Loading

0 comments on commit 8a1a26d

Please sign in to comment.