TitlePattern geocoder #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks for image titles that match the pattern:
These are then run through either the extended-grid geocoder or Google Maps. This results in changes in two situations:
alt_titlefield, which wasn't previously used by extended-grid, and wasn't consistently used by milstein.This results in 265 new items on the site, and 162 location changes. I reviewed 20 of these, 85% were wins and 15% were neutral (moving across an intersection).
On its own, this is able to geocode 23454 / 41463 = 56.6% of the items. This takes a lot of pressure off the downstream coders, and reduces reliance on the mysterious
addressfield from the 2013 CSV file, which has unclear provenance.