Skip to content
This repository has been archived by the owner on Dec 2, 2021. It is now read-only.

convert test-corpc-version to no pmix #259

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yulujia
Copy link
Contributor

@yulujia yulujia commented Nov 1, 2019

Signed-off-by: Yulu Jia [email protected]

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test.t_sub_group = crt_group_lookup("example_grpid");
D_ASSERT(test.t_sub_group != NULL);
rc = crt_rank_evict(test.t_local_group, rpc_req_input->rank);
// test.t_sub_group = crt_group_lookup("example_grpid");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(style) do not use C99 // comments

D_ASSERTF((cb_info->cci_rc == -DER_MISMATCH ||
cb_info->cci_rc == -DER_NONEXIST),
D_ASSERTF((cb_info->cci_rc == -DER_MISMATCH),
// || cb_info->cci_rc == -DER_NONEXIST),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(style) do not use C99 // comments

if (test.t_sub_group == NULL)
DBG_PRINT("!!!!!!!! t_sub_group shuold not be NULL\n");
D_ASSERTF(test.t_sub_group != NULL, "should not be NULL\n");
// rc = crt_rank_evict(test.t_primary_group, rpc_req_input->rank);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(style) do not use C99 // comments

rc = test_rank_evict(test.t_primary_group, test.t_crt_ctx,
2);
if (rc != DER_SUCCESS)
D_ERROR("crt_rank_evcit(grp=%p, rank=2) failed, rc %d\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(style) line over 80 characters

@@ -382,7 +366,8 @@ rank_evict_cb(crt_rpc_t *rpc_req)
if (rpc_req_output == NULL)
return -DER_INVAL;

excluded_membs.rl_nr = 3;
// excluded ranks contains secondary logical ranks
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(style) do not use C99 // comments

if (rc != DER_SUCCESS)
D_ERROR("crt_rank_evcit(grp=%p, rank=2) failed, rc %d\n",
test.t_local_group, rc);
// rc = crt_rank_evict(test.t_primary_group, 2);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(style) do not use C99 // comments

@daosbuild1
Copy link
Collaborator

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-259/1/execution/node/260/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-259/1/execution/node/257/log

@daosbuild1
Copy link
Collaborator

Test stage Build on SLES 12.3 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-259/1/execution/node/268/log

@daosbuild1
Copy link
Collaborator

Test stage Build on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-259/1/execution/node/284/log

@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 42.3 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-259/1/execution/node/350/log

@daosbuild1 daosbuild1 dismissed their stale review November 1, 2019 17:31

Updated patch

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-259/2/execution/node/288/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-259/3/execution/node/290/log

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants