CaRT-788 : Added new API to allow for reset of fabric interfaces on PSM2 when Eager message problems happen due to client reboots. #344

vschhabra · 2020-01-27T16:41:05Z

No description provided.

…SM2 when Eager message problems happen due to client reboots. Signed-off-by: Vikram Chhabra <[email protected]>

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-344/1/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

Note: Error annotation limited to the first 31 errors. Remaining unannotated errors:

src/cart/crt_hg.c:546:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:1116:
(style) code indent should use tabs where possible
(style) please, no space before tabs

src/cart/crt_hg.c:46:
(style) do not initialise globals to 0
(style) spaces required around that '=' (ctx:VxV)

src/cart/crt_hg.c:50:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:51:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:55:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:56:
(style) code indent should use tabs where possible
(style) please, no space before tabs

src/cart/crt_hg.c:57:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:59:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:60:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:62:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:68:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:69:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:1094:
(style) code indent should use tabs where possible
(style) please, no space before tabs

src/cart/crt_hg.c:1095:
(style) trailing whitespace
(style) code indent should use tabs where possible
(style) please, no space before tabs

src/cart/crt_hg.c:1097:
(style) code indent should use tabs where possible
(style) please, no space before tabs

src/cart/crt_hg.c:1098:
(style) line over 80 characters

src/cart/crt_hg.c:75:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:76:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:1101:
(style) code indent should use tabs where possible
(style) please, no space before tabs

src/cart/crt_hg.c:78:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:79:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:80:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:81:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:82:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:1107:
(style) code indent should use tabs where possible
(style) please, no space before tabs

src/cart/crt_hg.c:84:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:85:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:86:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:88:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:89:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:90:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:91:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:92:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:1117:
(style) trailing whitespace
(style) code indent should use tabs where possible
(style) please, no space before tabs

src/cart/crt_hg.c:94:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:95:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:1120:
(style) code indent should use tabs where possible
(style) please, no space before tabs

src/cart/crt_hg.c:1121:
(style) code indent should use tabs where possible
(style) please, no space before tabs

src/cart/crt_hg.c:98:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:1124:
(style) code indent should use tabs where possible
(style) please, no space before tabs

src/cart/crt_hg.c:1125:
(style) line over 80 characters

src/cart/crt_hg.c:1127:
(style) line over 80 characters
(style) code indent should use tabs where possible
(style) please, no space before tabs
(style) type 'long unsigned int' should be specified in [[un]signed] [short|int|long|long long] order
(style) space prohibited before that close parenthesis ')'

src/cart/crt_hg.c:104:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:1129:
(style) trailing whitespace

src/cart/crt_hg.c:106:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:107:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:113:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:115:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:116:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:121:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:123:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:125:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:127:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:133:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:135:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:136:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:137:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:138:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:144:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:145:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:147:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:148:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:149:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:150:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:152:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:158:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:159:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:160:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:162:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:163:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:169:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:175:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:176:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:177:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:178:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:179:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:180:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:801:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:802:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:803:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:804:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:805:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:806:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:807:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:808:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:1110:
(style) code indent should use tabs where possible
(style) please, no space before tabs

src/cart/crt_hg.c:1119:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:848:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:1103:
(style) else should follow close brace '}'

src/cart/crt_hg.c:1092:
(style) code indent should use tabs where possible
(style) please, no space before tabs

src/cart/crt_hg.c:1093:
(style) code indent should use tabs where possible
(style) please, no space before tabs

src/cart/crt_hg.c:1122:
(style) code indent should use tabs where possible
(style) please, no space before tabs

src/cart/crt_hg.c:1105:
(style) line over 80 characters

src/cart/crt_hg.c:1128:
(style) line over 80 characters
(style) code indent should use tabs where possible
(style) please, no space before tabs
(style) type 'long unsigned int' should be specified in [[un]signed] [short|int|long|long long] order
(style) space required after that ',' (ctx:VxV)
(style) space prohibited before that close parenthesis ')'

src/cart/crt_hg.c:1106:
(style) line over 80 characters
(style) code indent should use tabs where possible
(style) please, no space before tabs

src/cart/crt_hg.c:1102:
(style) code indent should use tabs where possible
(style) please, no space before tabs

src/cart/crt_hg.c:471:
(style) space prohibited between function name and open parenthesis '('

src/cart/crt_hg.c:473:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:475:
(style) code indent should use tabs where possible
(style) space prohibited before that close parenthesis ')'
(style) unnecessary whitespace before a quoted newline

src/cart/crt_hg.c:476:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:477:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:478:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:479:
(style) code indent should use tabs where possible
(style) please, no space before tabs

src/cart/crt_hg.c:480:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:1104:
(style) trailing whitespace

src/cart/crt_hg.c:482:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:483:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:484:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:485:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:486:
(style) code indent should use tabs where possible
(style) please, no space before tabs

src/cart/crt_hg.c:487:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:490:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:493:
(style) space prohibited between function name and open parenthesis '('

src/cart/crt_hg.c:495:
(style) code indent should use tabs where possible
(style) please, no space before tabs

src/cart/crt_hg.c:497:
(style) please, no space before tabs

src/cart/crt_hg.c:498:
(style) code indent should use tabs where possible
(style) please, no space before tabs

src/cart/crt_hg.c:500:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:501:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:502:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:503:
(style) line over 80 characters
(style) code indent should use tabs where possible

src/cart/crt_hg.c:504:
(style) code indent should use tabs where possible
(style) please, no space before tabs

src/cart/crt_hg.c:505:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:507:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:508:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:510:
(style) code indent should use tabs where possible

daosbuild1 · 2020-01-27T16:49:15Z

src/cart/crt_rpc.c

@@ -1139,7 +1139,8 @@ crt_req_send(crt_rpc_t *req, crt_cb_t complete_cb, void *arg)
 	 * function.  Referenced dropped at end of this function.
 	 */
 	RPC_ADDREF(rpc_priv);
-
+	/* Insert the local job id in the rpc request. */
+ 	rpc_priv->crp_req_hdr.cch_clid = crt_gdata.cg_clid;


(style) code indent should use tabs where possible
(style) please, no space before tabs

daosbuild1 · 2020-01-27T16:49:16Z

src/cart/crt_rpc.h

@@ -101,6 +101,8 @@ struct crt_common_hdr {
 	uint32_t	cch_xid;
 	/* used in crp_reply_hdr to propagate rpc failure back to sender */
 	uint32_t	cch_rc;
+        /* client id */


(style) code indent should use tabs where possible

daosbuild1 · 2020-01-27T16:49:16Z

src/cart/crt_rpc.h

@@ -101,6 +101,8 @@ struct crt_common_hdr {
 	uint32_t	cch_xid;
 	/* used in crp_reply_hdr to propagate rpc failure back to sender */
 	uint32_t	cch_rc;
+        /* client id */
+        uint64_t        cch_clid;


(style) code indent should use tabs where possible

daosbuild1 · 2020-01-27T16:49:16Z

src/include/cart/api.h

+int crt_hg_remove_client_id (uint64_t client_id);
+
+/* Test Function. */
+int crt_hg_remove_all_client_ids (void);


(style) space prohibited between function name and open parenthesis '('

daosbuild1 · 2020-01-27T16:49:16Z

src/include/cart/api.h

+ * return                       DER_SUCCESS on success, negative value on
+ *                              failure.
+ */
+int crt_hg_remove_client_id (uint64_t client_id);


(style) space prohibited between function name and open parenthesis '('

daosbuild1 · 2020-01-27T16:49:20Z

src/cart/crt_hg.c

+	while (hg_addr_table_index > 0) {
+		ret = crt_hg_remove_client_id (hg_addr_table[--hg_addr_table_index]);
+        	if (ret != HG_SUCCESS) {
+                	D_ERROR("crt_remove_addr_all failed, hg_ret %d.\n", ret);


(style) line over 80 characters
(style) code indent should use tabs where possible
(style) please, no space before tabs

daosbuild1 · 2020-01-27T16:49:20Z

src/cart/crt_hg.c

+		ret = crt_hg_remove_client_id (hg_addr_table[--hg_addr_table_index]);
+        	if (ret != HG_SUCCESS) {
+                	D_ERROR("crt_remove_addr_all failed, hg_ret %d.\n", ret);
+              		D_GOTO(out, ret = -DER_HG);


(style) code indent should use tabs where possible
(style) please, no space before tabs

daosbuild1 · 2020-01-27T16:49:20Z

src/cart/crt_hg.c

+        	if (ret != HG_SUCCESS) {
+                	D_ERROR("crt_remove_addr_all failed, hg_ret %d.\n", ret);
+              		D_GOTO(out, ret = -DER_HG);
+       	 	}


(style) code indent should use tabs where possible
(style) please, no space before tabs

daosbuild1 · 2020-01-27T16:49:21Z

src/cart/crt_hg.c

@@ -824,7 +1051,9 @@ crt_rpc_handler_common(hg_handle_t hg_hdl)
 	bool			 is_coll_req = false;
 	int			 rc = 0;
 	struct crt_rpc_priv	 rpc_tmp = {0};
-
+	d_list_t		*halink;
+	struct crt_ha_mapping 	*ha;


(style) please, no space before tabs

daosbuild1 · 2020-01-27T16:49:21Z

src/cart/crt_hg.c

-
+	d_list_t		*halink;
+	struct crt_ha_mapping 	*ha;
+ 	struct ha_entry 	ha_entry;


(style) code indent should use tabs where possible
(style) please, no space before tabs

daosbuild1 · 2020-01-27T16:49:27Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-344/1/execution/node/45/log

daosbuild1 · 2020-01-27T17:00:49Z

Test stage Build on Leap 15 with Intel-C completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-344/1/execution/node/380/log

frostedcmos · 2020-01-27T23:46:24Z

src/cart/crt_hg.c

+	d_list_t		*halink;
+	struct crt_ha_mapping 	*ha;
+ 	struct ha_entry 	ha_value;
+


the section from here on should be protected by some lock. its possible that client with same client_id connects as you are trying to destroy its entry, which can lead to race conditions

frostedcmos · 2020-01-27T23:51:14Z

src/cart/crt_hg.c

+{
+        hg_return_t     	ret = HG_SUCCESS;
+
+#ifdef HASH_TEST


why is it conditional? when server shuts down it needs to destroy all tables, which would execute similar code.

Thats some test code. I needed to have a copy of the client id's in the test application. Was using it for that purpose. Yes this may transfer into the shutdown case we had discussed.

frostedcmos · 2020-01-27T23:51:56Z

src/cart/crt_hg.c

-
+	/*Create the hg_addr hash table*/
+        rc = d_hash_table_create_inplace(D_HASH_FT_NOLOCK,
+                                        CRT_LOOKUP_CACHE_BITS,


this should be CRT_HG_ADDR_CACHE_LOOKUP_BITS

frostedcmos · 2020-01-27T23:53:58Z

src/cart/crt_hg.c

@@ -578,7 +797,15 @@ crt_hg_init(crt_phy_addr_t *addr, bool server)

 	D_DEBUG(DB_NET, "in crt_hg_init, listen address: %s.\n", *addr);
 	crt_gdata.cg_hg = hg_gdata;
-
+	/*Create the hg_addr hash table*/


this section should also be only done if psm2

frostedcmos · 2020-01-28T00:01:06Z

src/cart/crt_hg.c

+int
+crt_hg_remove_client_id (uint64_t client_id)
+{
+        hg_return_t     	ret = HG_SUCCESS;


there need to be checks here:

if (!is_service()) return -- only supported on clients

only for psm2

frostedcmos · 2020-01-28T00:02:13Z

src/cart/crt_hg.c

+int
+crt_hg_remove_client_id (uint64_t client_id)
+{
+        hg_return_t     	ret = HG_SUCCESS;


this should be int, we shouldnt reuse hg_return_t for our error codes

frostedcmos · 2020-01-28T00:03:02Z

src/cart/crt_hg.c

+int
+crt_hg_remove_addr (hg_class_t *hg_class, hg_addr_t hg_addr)
+{
+        hg_return_t     ret = HG_SUCCESS;


we shouldnt reuse hg return codes for our own return codes

frostedcmos · 2020-01-28T00:04:51Z

src/cart/crt_hg.c

+#endif
+
+struct ha_entry {
+        hg_class_t      *hg_class;


hg_class is associated with crt_context. As such we should keep the addr table per context and not store hg_class for each entry. In your current implementation (even if client id was unique), you would run into issues, since if client sends to server on address rank=0 tag=0 and on rank=0 tag=1, you will end up with 2 ha_entries for the same client id.

Storing this hash table per each context will save space.

Whenever hg_class is needed it can be derived from context in question from crt_ctx->cc_hg_ctx.chc.chc_hgcla

yulujia · 2020-01-29T19:16:03Z

src/cart/crt_hg.c

+        	}
+		else {
+			ha_entry.hg_class = hg_info->hg_class;	
+			HG_Addr_dup(hg_info->hg_class, hg_info->addr, &ha_entry.hg_addr);


this line may not work correctly after the mercury nameserver patch. In mercury the receiver side does not have the client's fi_addr. I haven't found the specific code where mercury constructs hg_info before calling this crt_rpc_handler_common(). I haven't found a way to let the receiver side retrieve the client's fi_addr on the fi/mercury level. We probably can do it on the cart level.

Signed-off-by: Vikram Chhabra <[email protected]>

Updated patch

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-344/2/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

Note: Error annotation limited to the first 31 errors. Remaining unannotated errors:

src/cart/crt_hg.c:1207:
(style) please, no space before tabs

src/cart/crt_hg.c:824:
(style) space prohibited before that close parenthesis ')'

src/cart/crt_hg.c:57:
(style) please, no space before tabs

src/cart/crt_hg.c:826:
(style) space prohibited before that close parenthesis ')'

src/cart/crt_hg.c:827:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:60:
(style) please, no space before tabs

src/cart/crt_hg.c:61:
(style) please, no space before tabs

src/cart/crt_hg.c:1214:
(style) please, no space before tabs

src/cart/crt_hg.c:63:
(style) please, no space before tabs

src/cart/crt_hg.c:1344:
(style) do not use C99 // comments

src/cart/crt_hg.c:1217:
(style) please, no space before tabs

src/cart/crt_hg.c:1218:
(style) please, no space before tabs

src/cart/crt_hg.c:1290:
(style) trailing whitespace

src/cart/crt_hg.c:845:
(style) space required after that ',' (ctx:VxV)

src/cart/crt_hg.c:1345:
(style) do not use C99 // comments

src/cart/crt_hg.c:56:
(style) please, no space before tabs

src/cart/crt_hg.c:853:
(style) space prohibited between function name and open parenthesis '('

src/cart/crt_hg.c:1337:
(style) line over 80 characters

src/cart/crt_hg.c:858:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:859:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:476:
(style) type 'long unsigned int' should be specified in [[un]signed] [short|int|long|long long] order
(style) space prohibited before that close parenthesis ')'

src/cart/crt_hg.c:478:
(style) type 'long unsigned int' should be specified in [[un]signed] [short|int|long|long long] order
(style) space prohibited before that close parenthesis ')'

src/cart/crt_hg.c:1317:
(style) else should follow close brace '}'

src/cart/crt_hg.c:1205:
(style) please, no space before tabs

src/cart/crt_hg.c:59:
(style) please, no space before tabs

src/cart/crt_hg.c:868:
(style) please, no space before tabs

src/cart/crt_hg.c:869:
(style) please, no space before tabs

src/cart/crt_hg.c:1255:
(style) trailing whitespace
(style) line over 80 characters

src/cart/crt_hg.c:872:
(style) please, no space before tabs

src/cart/crt_hg.c:1212:
(style) code indent should use tabs where possible
(style) please, no space before tabs

src/cart/crt_hg.c:876:
(style) do not use C99 // comments

src/cart/crt_hg.c:877:
(style) do not use C99 // comments

src/cart/crt_hg.c:1262:
(style) line over 80 characters

src/cart/crt_hg.c:1213:
(style) code indent should use tabs where possible
(style) please, no space before tabs

src/cart/crt_hg.c:500:
(style) please, no space before tabs

src/cart/crt_hg.c:885:
(style) do not use C99 // comments

src/cart/crt_hg.c:1308:
(style) line over 80 characters

src/cart/crt_hg.c:1271:
(style) line over 80 characters

src/cart/crt_hg.c:1144:
(style) line over 80 characters

src/cart/crt_hg.c:890:
(style) code indent should use tabs where possible
(style) please, no space before tabs

src/cart/crt_hg.c:1275:
(style) else should follow close brace '}'

src/cart/crt_hg.c:1276:
(style) line over 80 characters

src/cart/crt_hg.c:1301:
(style) line over 80 characters

src/cart/crt_group.c:2713:
(style) trailing whitespace

daosbuild1 · 2020-02-06T19:12:52Z

src/cart/crt_internal_types.h

@@ -165,6 +167,12 @@ struct crt_context {
 	crt_rpc_task_t		 cc_rpc_cb; /* rpc callback */
 	/* in-flight endpoint tracking hash table */
 	struct d_hash_table	 cc_epi_table;
+	/* hg addr hash tables */
+	struct d_hash_table 	 cc_ha_hash_table;


(style) please, no space before tabs

daosbuild1 · 2020-02-06T19:12:52Z

src/cart/crt_internal_types.h

@@ -165,6 +167,12 @@ struct crt_context {
 	crt_rpc_task_t		 cc_rpc_cb; /* rpc callback */
 	/* in-flight endpoint tracking hash table */
 	struct d_hash_table	 cc_epi_table;
+	/* hg addr hash tables */
+	struct d_hash_table 	 cc_ha_hash_table;
+	struct d_hash_table 	 cc_ha_server_hash_table;


(style) please, no space before tabs

daosbuild1 · 2020-02-06T19:12:52Z

src/cart/crt_internal_types.h

+	struct d_hash_table 	 cc_ha_hash_table;
+	struct d_hash_table 	 cc_ha_server_hash_table;
+	/* Locks associated with above hg addr tables. */
+	pthread_rwlock_t 	 cc_ha_hash_table_rwlock;


(style) please, no space before tabs

daosbuild1 · 2020-02-06T19:12:53Z

src/cart/crt_internal_types.h

+	struct d_hash_table 	 cc_ha_server_hash_table;
+	/* Locks associated with above hg addr tables. */
+	pthread_rwlock_t 	 cc_ha_hash_table_rwlock;
+	pthread_rwlock_t 	 cc_ha_server_hash_table_rwlock;


(style) please, no space before tabs

daosbuild1 · 2020-02-06T19:12:53Z

src/crt_launch/crt_launch.c

+	char			*p;
+	int			len;
+	int			rc;
+        crt_init_options_t      opt = {0};


(style) code indent should use tabs where possible

daosbuild1 · 2020-02-06T19:12:56Z

src/cart/crt_hg.c

+			ha = crt_ha_link2ptr(halink);
+			d_list_for_each_entry(ha_list_entry, &ha->chm_list,
+					chl_list_link) {
+				if ((ha_list_entry->chl_entry.ha_class == hg_info->hg_class)


(style) line over 80 characters

daosbuild1 · 2020-02-06T19:12:56Z

src/cart/crt_hg.c

+	const struct hg_info		*hg_info;
+	struct crt_rpc_priv		*rpc_priv;
+	crt_rpc_t			*rpc_pub;
+	crt_opcode_t		 	opc;


(style) please, no space before tabs

daosbuild1 · 2020-02-06T19:12:57Z

src/cart/crt_hg.c

+	struct crt_rpc_priv		*rpc_priv;
+	crt_rpc_t			*rpc_pub;
+	crt_opcode_t		 	opc;
+	crt_proc_t		 	proc = NULL;


(style) please, no space before tabs

daosbuild1 · 2020-02-06T19:12:57Z

src/cart/crt_hg.c

+
+	if (crt_gdata.cg_na_plugin == CRT_NA_OFI_PSM2) {
+		/*Create the hg_addr hash tables*/
+ 		rc = d_hash_table_create_inplace(D_HASH_FT_NOLOCK,


(style) code indent should use tabs where possible
(style) please, no space before tabs

daosbuild1 · 2020-02-06T19:12:57Z

src/cart/crt_hg.c

+	crt_proc_t		 	proc = NULL;
+	struct crt_opc_info		*opc_info = NULL;
+	hg_return_t		 	hg_ret = HG_SUCCESS;
+	bool			 	is_coll_req = false;


(style) please, no space before tabs

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-344/2/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

Note: Error annotation limited to the first 31 errors. Remaining unannotated errors:

src/cart/crt_hg.c:1207:
(style) please, no space before tabs

src/cart/crt_hg.c:824:
(style) space prohibited before that close parenthesis ')'

src/cart/crt_hg.c:57:
(style) please, no space before tabs

src/cart/crt_hg.c:826:
(style) space prohibited before that close parenthesis ')'

src/cart/crt_hg.c:827:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:60:
(style) please, no space before tabs

src/cart/crt_hg.c:61:
(style) please, no space before tabs

src/cart/crt_hg.c:1214:
(style) please, no space before tabs

src/cart/crt_hg.c:63:
(style) please, no space before tabs

src/cart/crt_hg.c:1344:
(style) do not use C99 // comments

src/cart/crt_hg.c:1217:
(style) please, no space before tabs

src/cart/crt_hg.c:1218:
(style) please, no space before tabs

src/cart/crt_hg.c:1290:
(style) trailing whitespace

src/cart/crt_hg.c:845:
(style) space required after that ',' (ctx:VxV)

src/cart/crt_hg.c:1345:
(style) do not use C99 // comments

src/cart/crt_hg.c:56:
(style) please, no space before tabs

src/cart/crt_hg.c:853:
(style) space prohibited between function name and open parenthesis '('

src/cart/crt_hg.c:1337:
(style) line over 80 characters

src/cart/crt_hg.c:858:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:859:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:476:
(style) type 'long unsigned int' should be specified in [[un]signed] [short|int|long|long long] order
(style) space prohibited before that close parenthesis ')'

src/cart/crt_hg.c:478:
(style) type 'long unsigned int' should be specified in [[un]signed] [short|int|long|long long] order
(style) space prohibited before that close parenthesis ')'

src/cart/crt_hg.c:1317:
(style) else should follow close brace '}'

src/cart/crt_hg.c:1205:
(style) please, no space before tabs

src/cart/crt_hg.c:59:
(style) please, no space before tabs

src/cart/crt_hg.c:868:
(style) please, no space before tabs

src/cart/crt_hg.c:869:
(style) please, no space before tabs

src/cart/crt_hg.c:1255:
(style) trailing whitespace
(style) line over 80 characters

src/cart/crt_hg.c:872:
(style) please, no space before tabs

src/cart/crt_hg.c:1212:
(style) code indent should use tabs where possible
(style) please, no space before tabs

src/cart/crt_hg.c:876:
(style) do not use C99 // comments

src/cart/crt_hg.c:877:
(style) do not use C99 // comments

src/cart/crt_hg.c:1262:
(style) line over 80 characters

src/cart/crt_hg.c:1213:
(style) code indent should use tabs where possible
(style) please, no space before tabs

src/cart/crt_hg.c:500:
(style) please, no space before tabs

src/cart/crt_hg.c:885:
(style) do not use C99 // comments

src/cart/crt_hg.c:1308:
(style) line over 80 characters

src/cart/crt_hg.c:1271:
(style) line over 80 characters

src/cart/crt_hg.c:1144:
(style) line over 80 characters

src/cart/crt_hg.c:890:
(style) code indent should use tabs where possible
(style) please, no space before tabs

src/cart/crt_hg.c:1275:
(style) else should follow close brace '}'

src/cart/crt_hg.c:1276:
(style) line over 80 characters

src/cart/crt_hg.c:1301:
(style) line over 80 characters

src/cart/crt_group.c:2713:
(style) trailing whitespace

daosbuild1 · 2020-02-06T19:13:08Z

src/cart/crt_internal_types.h

@@ -165,6 +167,12 @@ struct crt_context {
 	crt_rpc_task_t		 cc_rpc_cb; /* rpc callback */
 	/* in-flight endpoint tracking hash table */
 	struct d_hash_table	 cc_epi_table;
+	/* hg addr hash tables */
+	struct d_hash_table 	 cc_ha_hash_table;


(style) please, no space before tabs

daosbuild1 · 2020-02-06T19:13:08Z

src/cart/crt_internal_types.h

@@ -165,6 +167,12 @@ struct crt_context {
 	crt_rpc_task_t		 cc_rpc_cb; /* rpc callback */
 	/* in-flight endpoint tracking hash table */
 	struct d_hash_table	 cc_epi_table;
+	/* hg addr hash tables */
+	struct d_hash_table 	 cc_ha_hash_table;
+	struct d_hash_table 	 cc_ha_server_hash_table;


(style) please, no space before tabs

daosbuild1 · 2020-02-06T19:13:08Z

src/cart/crt_internal_types.h

+	struct d_hash_table 	 cc_ha_hash_table;
+	struct d_hash_table 	 cc_ha_server_hash_table;
+	/* Locks associated with above hg addr tables. */
+	pthread_rwlock_t 	 cc_ha_hash_table_rwlock;


(style) please, no space before tabs

daosbuild1 · 2020-02-06T19:13:08Z

src/cart/crt_internal_types.h

+	struct d_hash_table 	 cc_ha_server_hash_table;
+	/* Locks associated with above hg addr tables. */
+	pthread_rwlock_t 	 cc_ha_hash_table_rwlock;
+	pthread_rwlock_t 	 cc_ha_server_hash_table_rwlock;


(style) please, no space before tabs

daosbuild1 · 2020-02-06T19:13:09Z

src/crt_launch/crt_launch.c

+	char			*p;
+	int			len;
+	int			rc;
+        crt_init_options_t      opt = {0};


(style) code indent should use tabs where possible

daosbuild1 · 2020-02-06T19:13:13Z

src/cart/crt_hg.c

+			ha = crt_ha_link2ptr(halink);
+			d_list_for_each_entry(ha_list_entry, &ha->chm_list,
+					chl_list_link) {
+				if ((ha_list_entry->chl_entry.ha_class == hg_info->hg_class)


(style) line over 80 characters

daosbuild1 · 2020-02-06T19:13:13Z

src/cart/crt_hg.c

+	const struct hg_info		*hg_info;
+	struct crt_rpc_priv		*rpc_priv;
+	crt_rpc_t			*rpc_pub;
+	crt_opcode_t		 	opc;


(style) please, no space before tabs

daosbuild1 · 2020-02-06T19:13:13Z

src/cart/crt_hg.c

+	struct crt_rpc_priv		*rpc_priv;
+	crt_rpc_t			*rpc_pub;
+	crt_opcode_t		 	opc;
+	crt_proc_t		 	proc = NULL;


(style) please, no space before tabs

daosbuild1 · 2020-02-06T19:13:14Z

src/cart/crt_hg.c

+
+	if (crt_gdata.cg_na_plugin == CRT_NA_OFI_PSM2) {
+		/*Create the hg_addr hash tables*/
+ 		rc = d_hash_table_create_inplace(D_HASH_FT_NOLOCK,


(style) code indent should use tabs where possible
(style) please, no space before tabs

daosbuild1 · 2020-02-06T19:13:14Z

src/cart/crt_hg.c

+	crt_proc_t		 	proc = NULL;
+	struct crt_opc_info		*opc_info = NULL;
+	hg_return_t		 	hg_ret = HG_SUCCESS;
+	bool			 	is_coll_req = false;


(style) please, no space before tabs

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-344/2/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

Note: Error annotation limited to the first 0 errors. Remaining unannotated errors:

src/cart/crt_internal_types.h:171:
(style) please, no space before tabs

src/cart/crt_internal_types.h:172:
(style) please, no space before tabs

src/cart/crt_internal_types.h:174:
(style) please, no space before tabs

src/cart/crt_internal_types.h:175:
(style) please, no space before tabs

src/crt_launch/crt_launch.c:156:
(style) code indent should use tabs where possible

src/crt_launch/crt_launch.c:158:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:513:
(style) do not use C99 // comments

src/cart/crt_hg.c:899:
(style) line over 80 characters

src/cart/crt_hg.c:1284:
(style) line over 80 characters

src/cart/crt_hg.c:518:
(style) line over 80 characters

src/cart/crt_hg.c:1281:
(style) trailing whitespace

src/cart/crt_hg.c:904:
(style) line over 80 characters

src/cart/crt_hg.c:1132:
(style) space required before the open brace '{'

src/cart/crt_hg.c:906:
(style) code indent should use tabs where possible
(style) please, no space before tabs

src/cart/crt_hg.c:525:
(style) line over 80 characters

src/cart/crt_hg.c:529:
(style) line over 80 characters

src/cart/crt_hg.c:532:
(style) line over 80 characters

src/cart/crt_hg.c:1211:
(style) please, no space before tabs

src/cart/crt_hg.c:1302:
(style) line over 80 characters

src/cart/crt_hg.c:1303:
(style) line over 80 characters

src/cart/crt_hg.c:540:
(style) line over 80 characters

src/cart/crt_hg.c:1312:
(style) line over 80 characters

src/cart/crt_hg.c:902:
(style) line over 80 characters
(style) space prohibited between function name and open parenthesis '('

src/cart/crt_hg.c:1208:
(style) please, no space before tabs

src/cart/crt_hg.c:1289:
(style) trailing whitespace

src/cart/crt_hg.c:1327:
(style) line over 80 characters

src/cart/crt_hg.c:1288:
(style) line over 80 characters

src/cart/crt_hg.c:1202:
(style) please, no space before tabs

src/cart/crt_hg.c:1203:
(style) please, no space before tabs

src/cart/crt_hg.c:990:
(style) code indent should use tabs where possible
(style) please, no space before tabs

src/cart/crt_hg.c:1206:
(style) please, no space before tabs

src/cart/crt_hg.c:1207:
(style) please, no space before tabs

src/cart/crt_hg.c:824:
(style) space prohibited before that close parenthesis ')'

src/cart/crt_hg.c:57:
(style) please, no space before tabs

src/cart/crt_hg.c:826:
(style) space prohibited before that close parenthesis ')'

src/cart/crt_hg.c:827:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:60:
(style) please, no space before tabs

src/cart/crt_hg.c:61:
(style) please, no space before tabs

src/cart/crt_hg.c:1214:
(style) please, no space before tabs

src/cart/crt_hg.c:63:
(style) please, no space before tabs

src/cart/crt_hg.c:1344:
(style) do not use C99 // comments

src/cart/crt_hg.c:1217:
(style) please, no space before tabs

src/cart/crt_hg.c:1218:
(style) please, no space before tabs

src/cart/crt_hg.c:1290:
(style) trailing whitespace

src/cart/crt_hg.c:845:
(style) space required after that ',' (ctx:VxV)

src/cart/crt_hg.c:1345:
(style) do not use C99 // comments

src/cart/crt_hg.c:56:
(style) please, no space before tabs

src/cart/crt_hg.c:853:
(style) space prohibited between function name and open parenthesis '('

src/cart/crt_hg.c:1337:
(style) line over 80 characters

src/cart/crt_hg.c:858:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:859:
(style) code indent should use tabs where possible

src/cart/crt_hg.c:476:
(style) type 'long unsigned int' should be specified in [[un]signed] [short|int|long|long long] order
(style) space prohibited before that close parenthesis ')'

src/cart/crt_hg.c:478:
(style) type 'long unsigned int' should be specified in [[un]signed] [short|int|long|long long] order
(style) space prohibited before that close parenthesis ')'

src/cart/crt_hg.c:1317:
(style) else should follow close brace '}'

src/cart/crt_hg.c:1205:
(style) please, no space before tabs

src/cart/crt_hg.c:59:
(style) please, no space before tabs

src/cart/crt_hg.c:868:
(style) please, no space before tabs

src/cart/crt_hg.c:869:
(style) please, no space before tabs

src/cart/crt_hg.c:1255:
(style) trailing whitespace
(style) line over 80 characters

src/cart/crt_hg.c:872:
(style) please, no space before tabs

src/cart/crt_hg.c:1212:
(style) code indent should use tabs where possible
(style) please, no space before tabs

src/cart/crt_hg.c:876:
(style) do not use C99 // comments

src/cart/crt_hg.c:877:
(style) do not use C99 // comments

src/cart/crt_hg.c:1262:
(style) line over 80 characters

src/cart/crt_hg.c:1213:
(style) code indent should use tabs where possible
(style) please, no space before tabs

src/cart/crt_hg.c:500:
(style) please, no space before tabs

src/cart/crt_hg.c:885:
(style) do not use C99 // comments

src/cart/crt_hg.c:1308:
(style) line over 80 characters

src/cart/crt_hg.c:1271:
(style) line over 80 characters

src/cart/crt_hg.c:1144:
(style) line over 80 characters

src/cart/crt_hg.c:890:
(style) code indent should use tabs where possible
(style) please, no space before tabs

src/cart/crt_hg.c:1275:
(style) else should follow close brace '}'

src/cart/crt_hg.c:1276:
(style) line over 80 characters

src/cart/crt_hg.c:1301:
(style) line over 80 characters

src/cart/crt_group.c:2713:
(style) trailing whitespace

Note: Unable to provide any annotated comments due to GitHub API limitations.

daosbuild1 · 2020-02-06T19:13:27Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-344/2/execution/node/45/log

daosbuild1 · 2020-02-06T19:15:40Z

Test stage Build RPM on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-344/2/execution/node/274/log

daosbuild1 · 2020-02-06T19:16:43Z

Test stage Build RPM on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-344/2/execution/node/272/log

daosbuild1 · 2020-02-06T19:17:10Z

Test stage Build on Ubuntu 18.04 with Clang completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-344/2/execution/node/269/log

daosbuild1 · 2020-02-06T19:17:32Z

Test stage Build on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-344/2/execution/node/231/log

daosbuild1 · 2020-02-06T19:17:35Z

Test stage Build on CentOS 7 with Clang completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-344/2/execution/node/268/log

daosbuild1 · 2020-02-06T19:19:38Z

Test stage Build on Leap 15 with Intel-C completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-344/2/execution/node/273/log

Signed-off-by: Vikram Chhabra <[email protected]>

Updated patch

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-344/3/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

daosbuild1 · 2020-02-06T20:02:30Z

src/cart/crt_internal_types.h

+	struct d_hash_table	cc_ha_hash_table;
+	struct d_hash_table	cc_ha_server_hash_table;
+	/* Locks associated with above hg addr tables. */
+	pthread_rwlock_t 	cc_ha_hash_table_rwlock;


(style) please, no space before tabs

daosbuild1 · 2020-02-06T20:02:31Z

src/cart/crt_internal_types.h

+	struct d_hash_table	cc_ha_server_hash_table;
+	/* Locks associated with above hg addr tables. */
+	pthread_rwlock_t 	cc_ha_hash_table_rwlock;
+	pthread_rwlock_t 	cc_ha_server_hash_table_rwlock;


(style) please, no space before tabs

daosbuild1 · 2020-02-06T20:02:31Z

src/cart/crt_hg.c

+
+	if (crt_gdata.cg_na_plugin == CRT_NA_OFI_PSM2) {
+		/*Create the hg_addr hash tables*/
+ 		rc = d_hash_table_create_inplace(D_HASH_FT_NOLOCK,


(style) code indent should use tabs where possible
(style) please, no space before tabs

daosbuild1 · 2020-02-06T20:02:31Z

src/cart/crt_hg.c

+		if (halink != NULL) {
+			/*Traverse the list and add new entry to tail
+  			 *if not found. 
+  			 */


(style) code indent should use tabs where possible
(style) please, no space before tabs

daosbuild1 · 2020-02-06T20:02:31Z

src/cart/crt_hg.c

+					!= NULL) {
+			ha_value = entry->chl_entry;
+			D_FREE(entry);
+			rc = crt_hg_remove_addr (ha_value.ha_class,


(style) space prohibited between function name and open parenthesis '('

daosbuild1 · 2020-02-06T20:02:32Z

src/cart/crt_hg.c

+	int				ret = 0;
+	d_list_t			*halink;
+	struct crt_ha_mapping		*ha;
+	struct ha_entry 		ha_value;


(style) please, no space before tabs

daosbuild1 · 2020-02-06T20:02:32Z

src/cart/crt_hg.c

+		halink = d_hash_rec_find(&crt_ctx->cc_ha_server_hash_table,
+				(void *)&client_id, sizeof(client_id));
+		if (!halink) {
+        		D_ERROR("client=%" PRIu64 "not in server hash table\n",


(style) code indent should use tabs where possible
(style) please, no space before tabs

daosbuild1 · 2020-02-06T20:02:32Z

src/cart/crt_hg.c

+		if (rc != HG_SUCCESS) {
+			D_ERROR("crt_remove_addr failed, hg_ret %d.\n", rc);
+		}
+                D_FREE(entry);


(style) code indent should use tabs where possible

daosbuild1 · 2020-02-06T20:02:33Z

src/cart/crt_hg.c

+			D_ERROR("crt_remove_addr failed, hg_ret %d.\n", rc);
+		}
+                D_FREE(entry);
+        }


(style) code indent should use tabs where possible

daosbuild1 · 2020-02-06T20:02:33Z

src/cart/crt_group.c

@@ -2709,6 +2709,9 @@ crt_group_rank_remove_internal(struct crt_grp_priv *grp_priv, d_rank_t rank)

 		d_hash_rec_delete(&grp_priv->gp_uri_lookup_cache,
 			&rank, sizeof(d_rank_t));
+		/*If PSM2 then remove the rank from the hash table. */
+		if (crt_gdata.cg_na_plugin == CRT_NA_OFI_PSM2) 


(style) trailing whitespace

daosbuild1 · 2020-02-06T20:02:37Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-344/3/execution/node/45/log

daosbuild1 · 2020-02-06T20:04:54Z

Test stage Build RPM on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-344/3/execution/node/273/log

Updated patch

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-344/4/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

daosbuild1 · 2020-02-06T20:32:47Z

src/cart/crt_hg.c

+					!= NULL) {
+			ha_value = entry->chl_entry;
+			D_FREE(entry);
+			rc = crt_hg_remove_addr (ha_value.ha_class,


(style) space prohibited between function name and open parenthesis '('

daosbuild1 · 2020-02-06T20:32:48Z

src/cart/crt_hg.c

+				sizeof(client_id));
+		if (halink != NULL) {
+			/*Traverse the list and add new entry to tail
+			*if not found. 


(style) trailing whitespace

daosbuild1 · 2020-02-06T20:32:50Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-344/4/execution/node/45/log

daosbuild1 · 2020-02-06T20:35:06Z

Test stage Build RPM on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-344/4/execution/node/272/log

daosbuild1 · 2020-02-06T20:36:19Z

Test stage Build RPM on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-344/4/execution/node/271/log

daosbuild1 · 2020-02-06T20:36:55Z

Test stage Build on CentOS 7 with Clang completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-344/4/execution/node/270/log

daosbuild1 · 2020-02-06T20:36:58Z

Test stage Build on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-344/4/execution/node/244/log

daosbuild1 · 2020-02-06T20:39:00Z

Test stage Build on Ubuntu 18.04 with Clang completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-344/4/execution/node/274/log

daosbuild1 · 2020-02-06T20:39:05Z

Test stage Build on Leap 15 with Intel-C completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-344/4/execution/node/273/log

Signed-off-by: Vikram Chhabra <[email protected]>

Updated patch

daosbuild1 · 2020-02-06T20:53:31Z

Test stage Build RPM on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-344/5/execution/node/272/log

daosbuild1 · 2020-02-06T20:54:39Z

Test stage Build RPM on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-344/5/execution/node/246/log

daosbuild1 · 2020-02-06T20:55:16Z

Test stage Build on CentOS 7 with Clang completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-344/5/execution/node/270/log

daosbuild1 · 2020-02-06T20:55:19Z

Test stage Build on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-344/5/execution/node/273/log

daosbuild1 · 2020-02-06T20:57:12Z

Test stage Build on Ubuntu 18.04 with Clang completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-344/5/execution/node/271/log

daosbuild1 · 2020-02-06T20:57:20Z

Test stage Build on Leap 15 with Intel-C completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-344/5/execution/node/274/log

frostedcmos

first round of comments. General comment - make sure to update copyright dates on all changed files if they arent 2020 already

frostedcmos · 2020-02-07T02:19:01Z

src/include/cart/api.h

+ * Remove a client id from the Server hash table of Hg and Fabric Interface
+ * addresses.
+ *
+ * param[in] client_id          System wide unique client id


needs to be \param per doxygen format

frostedcmos · 2020-02-07T02:19:14Z

src/include/cart/api.h

+ *
+ * param[in] client_id          System wide unique client id
+ *
+ * return                       DER_SUCCESS on success, negative value on


needs to be \return

frostedcmos · 2020-02-07T02:20:35Z

src/include/cart/api.h

@@ -1946,6 +1946,17 @@ int crt_group_secondary_modify(crt_group_t *grp, d_rank_list_t *sec_ranks,
 			d_rank_list_t *prim_ranks, crt_group_mod_op_t op,
 			uint32_t version);

+/**
+ * Remove a client id from the Server hash table of Hg and Fabric Interface
+ * addresses.


I would prefer to not get into details of what we do, so remove references to hg/itnerface here.

Just make it something like crt_cleanup_client_id(). In notes to this api you can mention that for now it is only to be called when psm2 is used and client exists abruptly

frostedcmos · 2020-02-07T02:28:25Z

src/cart/crt_hg.c

+	D_DEBUG(DB_TRACE, "removing hg addr %" PRIu64 "\n",
+			(uint64_t)hg_addr);
+	D_DEBUG(DB_TRACE, "removing  hg class %" PRIu64 "\n",
+			(uint64_t)hg_class);


better to combine these 2 into single log line. on busy systems this can end up being printed far apart with multiple threads logging stuff, so we might lose track of what things go together

frostedcmos · 2020-02-07T02:28:46Z

src/cart/crt_hg.c

+			(uint64_t)hg_class);
+	ret = HG_Addr_set_remove(hg_class, hg_addr);
+	if (ret != HG_SUCCESS) {
+		D_ERROR("HG_Addr_set_remove) failed, hg_ret %d.\n", ret);


missing ( in text message

frostedcmos · 2020-02-07T02:37:31Z

src/cart/crt_hg.c

+		rc = crt_hg_remove_addr(ha_value.ha_class, ha_value.ha_addr);
+
+		if (rc != HG_SUCCESS) {
+			D_ERROR("crt_remove_addr failed, hg_ret %d.\n", rc);


same as before - it would be helpful to print ha_class/addr/client id here

Its being done in remove_addr call. Would be redundant here?

frostedcmos · 2020-02-07T02:38:21Z

src/cart/crt_hg.c

+	return rc;
+}
+
+int


it probably would help to add comment here to explain that this function is for server hash tables only

frostedcmos · 2020-02-07T02:39:00Z

src/cart/crt_hg.c

+		if (!halink) {
+			D_ERROR("client=%" PRIu64 "not in server hash table\n",
+				client_id);
+			D_GOTO(out, rc = -DER_NONEXIST);


need to unlock all locks here before you exit, or do this at 'out/cleanup' lable

frostedcmos · 2020-02-07T02:42:07Z

src/cart/crt_hg.c

+		D_RWLOCK_WRLOCK(&crt_ctx->cc_ha_server_hash_table_rwlock);
+		halink = d_hash_rec_find(&crt_ctx->cc_ha_server_hash_table,
+				(void *)&client_id, sizeof(client_id));
+		if (!halink) {


is this an error though? we can have entry in one context table but not in others. if this doesnt find in first table it will skip all other context tables.

The scenario where this can happen:
servers have multiple contexts
server0 sends rpc to server1 on tag=3
this will result in server1's context[3] table to be populated with server0's address/info, but no other context table will be

i will just log the error and do a continue;

frostedcmos · 2020-02-07T02:44:23Z

src/cart/crt_hg.c

+			rc = crt_hg_remove_addr(ha_value.ha_class,
+					ha_value.ha_addr);
+			if (rc != HG_SUCCESS) {
+				D_ERROR("crt_remove_addr failed, hg_ret %d.\n",


as before, helpful to print ha_class/addr/cli_id here for later debug

Its being done inside hg_remove_addr. Would be redundant?

Signed-off-by: Vikram Chhabra <[email protected]>

Conflicts: src/include/cart/api.h

Signed-off-by: Vikram Chhabra <[email protected]>

daosbuild1 · 2020-02-19T18:22:31Z

Test stage Build RPM on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-344/6/execution/node/257/log

daosbuild1 · 2020-02-19T18:23:06Z

Test stage Build RPM on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-344/6/execution/node/256/log

daosbuild1 · 2020-02-19T18:26:29Z

Test stage Build on Ubuntu 18.04 with Clang completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-344/6/execution/node/273/log

Signed-off-by: Vikram Chhabra <[email protected]>

daosbuild1 · 2020-02-19T21:13:56Z

Test stage Build RPM on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-344/7/execution/node/272/log

daosbuild1 · 2020-02-19T21:14:27Z

Test stage Build RPM on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-344/7/execution/node/274/log

Signed-off-by: Vikram Chhabra <[email protected]>

daosbuild1 · 2020-02-19T22:32:50Z

Test stage Build RPM on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-344/8/execution/node/274/log

daosbuild1 · 2020-02-19T22:33:42Z

Test stage Build RPM on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-344/8/execution/node/271/log

vschhabra added 2 commits January 27, 2020 16:36

CaRT-788 : Added new API to allow for reset of fabric interfaces on P…

09c24ec

…SM2 when Eager message problems happen due to client reboots. Signed-off-by: Vikram Chhabra <[email protected]>

Merge branch 'master' into vchhabra/psm2patch

242af79

daosbuild1 previously requested changes Jan 27, 2020

View reviewed changes

vschhabra requested review from frostedcmos and yulujia January 27, 2020 16:57

frostedcmos reviewed Jan 28, 2020

View reviewed changes

yulujia reviewed Jan 29, 2020

View reviewed changes

vschhabra added 2 commits February 6, 2020 19:08

CART-788: New API for PSM2 provider to fix eager message issues.

be0983a

Signed-off-by: Vikram Chhabra <[email protected]>

Merge branch 'master' into vchhabra/psm2patch

09b75db

daosbuild1 previously requested changes Feb 6, 2020

View reviewed changes

vschhabra added 2 commits February 6, 2020 19:58

Fixed whitespace issues

ccd051b

Signed-off-by: Vikram Chhabra <[email protected]>

Merge branch 'master' into vchhabra/psm2patch

595b115

daosbuild1 previously requested changes Feb 6, 2020

View reviewed changes

checkpatch failures

8dfc691

Signed-off-by: Vikram Chhabra <[email protected]>

frostedcmos reviewed Feb 7, 2020

View reviewed changes

vschhabra added 3 commits February 19, 2020 17:43

CART-788: Fixes for PSM2

700d7ce

Signed-off-by: Vikram Chhabra <[email protected]>

Merge branch 'master' into vchhabra/psm2patch

c1f7d05

Conflicts: src/include/cart/api.h

CaRT788: Getting mercury patch

902a83b

Signed-off-by: Vikram Chhabra <[email protected]>

Fixed build error.

8dac3aa

Signed-off-by: Vikram Chhabra <[email protected]>

Fixed CentOS build error

707d365

Signed-off-by: Vikram Chhabra <[email protected]>

CaRT-788 : Added new API to allow for reset of fabric interfaces on PSM2 when Eager message problems happen due to client reboots. #344

Are you sure you want to change the base?

CaRT-788 : Added new API to allow for reset of fabric interfaces on PSM2 when Eager message problems happen due to client reboots. #344

Conversation

vschhabra commented Jan 27, 2020

daosbuild1 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daosbuild1 commented Jan 27, 2020

daosbuild1 commented Jan 27, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daosbuild1 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daosbuild1 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 commented Feb 6, 2020

daosbuild1 commented Feb 6, 2020

daosbuild1 commented Feb 6, 2020

daosbuild1 commented Feb 6, 2020

daosbuild1 commented Feb 6, 2020

daosbuild1 commented Feb 6, 2020

daosbuild1 commented Feb 6, 2020

daosbuild1 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daosbuild1 commented Feb 6, 2020

daosbuild1 commented Feb 6, 2020

daosbuild1 left a comment

Choose a reason for hiding this comment