Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New DAOcreator UI Embedded #1506

Merged
merged 33 commits into from
Mar 24, 2020
Merged

Conversation

dOrgJelli
Copy link
Contributor

paste

@cbrzn cbrzn force-pushed the daocreator-v2-embed branch from 9a00822 to 807c32d Compare March 13, 2020 12:28
@cbrzn cbrzn force-pushed the daocreator-v2-embed branch from 807c32d to d459ee2 Compare March 13, 2020 14:55
@cbrzn cbrzn force-pushed the daocreator-v2-embed branch from a3fd4e5 to b80ca40 Compare March 14, 2020 17:22
@cbrzn cbrzn force-pushed the daocreator-v2-embed branch from b80ca40 to 712b522 Compare March 14, 2020 17:47
@orenyodfat
Copy link
Contributor

@cbrzn travis fail :(

@orenyodfat
Copy link
Contributor

@dOrgJelli is that only a UI update ?

@orenyodfat
Copy link
Contributor

@tibetsprague @dkent600 any idea why test fail ?

@orenyodfat orenyodfat temporarily deployed to alchemy-daocreator-v2-e-qyixad March 19, 2020 17:24 Inactive
@orenyodfat orenyodfat temporarily deployed to alchemy-daocreator-v2-e-qyixad March 20, 2020 03:36 Inactive
@orenyodfat orenyodfat temporarily deployed to alchemy-daocreator-v2-e-qyixad March 20, 2020 03:54 Inactive
@orenyodfat orenyodfat temporarily deployed to alchemy-daocreator-v2-e-qyixad March 20, 2020 04:08 Inactive
@EzraWeller
Copy link
Contributor

Looks good to me. The one small change I suggest before merging is to give at least an estimate of how many transactions to wait for once you've started "installing" the organization.

@orishim
Copy link
Contributor

orishim commented Mar 23, 2020

Looks good to me. The one small change I suggest before merging is to give at least an estimate of how many transactions to wait for once you've started "installing" the organization.

Created an issue for this here. For now we can just add the following warning:

Installation can require between 2 - 8 transactions. Please confirm all transactions you are prompted to sign.

What do you think @cbrzn @dOrgJelli ?

@dkent600
Copy link
Contributor

dkent600 commented Mar 23, 2020

@dOrgJelli Fix the merge conflicts and I'll merge this.

@dOrgJelli
Copy link
Contributor Author

@dkent600 merged

@orenyodfat orenyodfat temporarily deployed to alchemy-daocreator-v2-e-qyixad March 23, 2020 21:17 Inactive
@dOrgJelli
Copy link
Contributor Author

@EzraWeller @orishim left a comment on the issue Ori created.

@dkent600 dkent600 merged commit 408a983 into daostack:dev Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants