Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to create components in resources folder to kubernetes #1473

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

filintod
Copy link
Contributor

@filintod filintod commented Dec 8, 2024

Description

Allow to create/update components into cluster when running app. A follow up to #1462 and why it has more files than just for the component creation. I'll rebase after

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@filintod filintod requested review from a team as code owners December 8, 2024 17:42
@filintod filintod force-pushed the filinto/add-component branch from 3e1ec31 to 245d50c Compare December 8, 2024 18:03
@@ -140,11 +157,7 @@ func Run(runFilePath string, config runfileconfig.RunFileConfig) (bool, error) {

// create default deployment config.
dep := createDeploymentConfig(daprClient, app)
if err != nil {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this error is always nil at this point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants