-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dapr client registration consolidation #1417
Conversation
Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
… IConfiguration. Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1417 +/- ##
==========================================
+ Coverage 67.28% 70.03% +2.74%
==========================================
Files 174 196 +22
Lines 6025 6564 +539
Branches 671 715 +44
==========================================
+ Hits 4054 4597 +543
Misses 1802 1802
+ Partials 169 165 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This PR is no longer necessary as most of it was included in #1382 |
Description
I updated the Jobs and Messaging client builder factories to achieve some uniformity with the other client builders so they all allow client configuration via IConfiguration when available via DI.
This approach means we don't have to do either of the following:
Action<DaprClientBuilder>?
into everyAddXClient()
methodDaprClient
that's used by all Dapr clients for a singular means of configuring Dapr clientsI also consolidated several methods to Dapr.Common that were duplicated throughout the builders. Once #1382 is merged, I'll also mirror these changes to it, but Workflows should already be covered, though it uses a completely different builder style.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: