Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for stateManagerCtx #558

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
+2,130 −72
Open

Add tests for stateManagerCtx #558

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
99bc8dc
tests: mockgen mock_client file
KentHsu May 1, 2024
977a3e5
fix: fix setWithTTL method
KentHsu May 1, 2024
e1eaf71
tests: add tests for stateManagerCtx
KentHsu May 1, 2024
a2693e4
tests: fix testifylint error
KentHsu May 2, 2024
69de03d
tests: add newStateManager and rename newStateManagerCtx
KentHsu May 2, 2024
9481caf
tests: add tests for both stateManager and stateManagerCtx
KentHsu May 2, 2024
c41850f
Revert "tests: add tests for both stateManager and stateManagerCtx"
KentHsu May 2, 2024
644e1aa
tests: copy stateManagerCtx tests to stateManager
KentHsu May 2, 2024
71fda3e
chore: add a new target mock in Makefile and update mock files
KentHsu May 3, 2024
be6e8ce
chore: add mocks in .codecov.yaml
KentHsu May 3, 2024
b29311b
Revert "chore: add mocks in .codecov.yaml"
KentHsu May 6, 2024
fe98607
chore: replace gomock with Uber's fork
KentHsu May 6, 2024
0a9fb27
Merge branch 'main' into add-tests-for-stateManagerCtx
KentHsu May 7, 2024
40c60b0
chore: run go mod tidy
KentHsu May 7, 2024
d3899bf
Merge branch 'main' into add-tests-for-stateManagerCtx
KentHsu Jul 23, 2024
735f112
chore: update go.mod with Uber's gomock fork
KentHsu Jul 23, 2024
4b0276c
tests: regenerate mocks
KentHsu Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: fix setWithTTL method 
Signed-off-by: KentHsu <chiahaohsu9@gmail.com>
@KentHsu
KentHsu committed May 1, 2024
commit 977a3e5f9b7d40f2aaceeae0da40c2676b6be362
2 changes: 1 addition & 1 deletion actor/state/state_manager.go
View file
Original file line number Diff line number Diff line change
@@ -167,7 +167,7 @@ func (s *stateManagerCtx) SetWithTTL(_ context.Context, stateName string, value
if metadata.Kind == None || metadata.Kind == Remove {
metadata.Kind = Update
}
s.stateChangeTracker.Store(stateName, NewChangeMetadata(metadata.Kind, value))
s.stateChangeTracker.Store(stateName, NewChangeMetadata(metadata.Kind, value).WithTTL(ttl))
return nil
}
s.stateChangeTracker.Store(stateName, (&ChangeMetadata{