-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the holopin.yaml to use the sdk badge #590
Conversation
Hello @AjaySDwivedi1, welcome to this SDK 👋🏻 Can you please fix the DCO? |
I added to the another commit. Let me know if that wrong and I'll do it again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AjaySDwivedi1 existing content of the holopin.yaml file should be removed. Only the YAML that is mentioned in the issue should be present in the file. Thank you!
Hey, I made the necessary changes. Let me know if I need to do anything else! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@marcduiker Did do the DCO right? The merge for the PR is still blocked. If I need to fix something let me know. |
@AjaySDwivedi1 The DCO/sign-off is missing from the initial commit. I think this should do it:
|
Signed-off-by: AjaySDwivedi1 <[email protected]>
Signed-off-by: AjaySDwivedi1 <[email protected]>
Signed-off-by: AjaySDwivedi1 <[email protected]>
@marcduiker Thank you! I was able to do the DOC right this time! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AjaySDwivedi1 for the PR and @marcduiker for your review, LGTM!
@holopin-bot @AjaySDwivedi1 Thank you for this contribution! |
Congratulations @AjaySDwivedi1, you just earned a badge! Here it is: https://holopin.io/claim/clvc3nihd91280fl8aal67evs This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Description
Please explain the changes you've made
Added code from issue #589 to holopin.yml
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #589
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: