Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the holopin.yaml to use the sdk badge #590

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

AjaySDwivedi1
Copy link
Contributor

Description

Please explain the changes you've made
Added code from issue #589 to holopin.yml

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #589

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@AjaySDwivedi1 AjaySDwivedi1 requested review from a team as code owners April 10, 2024 18:31
@shubham1172
Copy link
Member

Hello @AjaySDwivedi1, welcome to this SDK 👋🏻 Can you please fix the DCO?

image

@AjaySDwivedi1
Copy link
Contributor Author

Hello @AjaySDwivedi1, welcome to this SDK 👋🏻 Can you please fix the DCO?

image

I added to the another commit. Let me know if that wrong and I'll do it again.

Copy link
Contributor

@marcduiker marcduiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AjaySDwivedi1 existing content of the holopin.yaml file should be removed. Only the YAML that is mentioned in the issue should be present in the file. Thank you!

@AjaySDwivedi1
Copy link
Contributor Author

Hi @AjaySDwivedi1 existing content of the holopin.yaml file should be removed. Only the YAML that is mentioned in the issue should be present in the file. Thank you!

Hey, I made the necessary changes. Let me know if I need to do anything else!

Copy link
Contributor

@marcduiker marcduiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AjaySDwivedi1
Copy link
Contributor Author

@marcduiker Did do the DCO right? The merge for the PR is still blocked. If I need to fix something let me know.

@marcduiker
Copy link
Contributor

@marcduiker Did do the DCO right? The merge for the PR is still blocked. If I need to fix something let me know.

@AjaySDwivedi1 The DCO/sign-off is missing from the initial commit.

I think this should do it:

git rebase --signoff HEAD~3
git push -f

@AjaySDwivedi1
Copy link
Contributor Author

@marcduiker Thank you! I was able to do the DOC right this time!

Copy link
Member

@shubham1172 shubham1172 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AjaySDwivedi1 for the PR and @marcduiker for your review, LGTM!

@shubham1172 shubham1172 added this pull request to the merge queue Apr 23, 2024
Merged via the queue into dapr:main with commit 75cdea9 Apr 23, 2024
5 of 6 checks passed
@marcduiker
Copy link
Contributor

@holopin-bot @AjaySDwivedi1 Thank you for this contribution!

Copy link

holopin-bot bot commented Apr 23, 2024

Congratulations @AjaySDwivedi1, you just earned a badge! Here it is: https://holopin.io/claim/clvc3nihd91280fl8aal67evs

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the holopin.yaml to use the sdk badge
3 participants