Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix path for getting started documentation #652

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

RafaelJCamara
Copy link
Contributor

Description

The / in the path makes all the difference when it comes to loading the images in the page.

Look how it looks without the /:
image

If you look at the request that is made it's missing the /js in the path:
image

With the /:
image

The network request:
image

Issue reference

No issue referenced.

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@RafaelJCamara RafaelJCamara requested review from a team as code owners December 3, 2024 17:35
Copy link
Member

@mikeee mikeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, lgtm

@dapr-bot
Copy link
Collaborator

dapr-bot commented Jan 4, 2025

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot added the stale label Jan 4, 2025
@dapr-bot
Copy link
Collaborator

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot closed this Jan 11, 2025
@RafaelJCamara
Copy link
Contributor Author

Ping for merge

@mikeee mikeee reopened this Jan 11, 2025
@dapr-bot dapr-bot removed the stale label Jan 11, 2025
@WhitWaldo WhitWaldo added this pull request to the merge queue Jan 15, 2025
Merged via the queue into dapr:main with commit 330aa92 Jan 15, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants