-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch error in sdk when workflow instance not found #771
Catch error in sdk when workflow instance not found #771
Conversation
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.15 #771 +/- ##
===============================================
Coverage ? 86.29%
===============================================
Files ? 89
Lines ? 5029
Branches ? 0
===============================================
Hits ? 4340
Misses ? 689
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second thought I do see the sense of wrapping the not found to a None
return and raising anything else. Seeing if it's there or not will be the most common check I imagine.
I have a question on the detection of the not found.
Signed-off-by: Elena Kolevska <[email protected]>
Description
Catches error from daprd in the sdk when workflow instance not found, so that users don't have to do try/catch in the app.
Instead, when daprd can't find the workflow instance
get_workflow_state
will returnNone
, as specified in the doc comment.Also adds a small demo workflows examples fix.
Issue reference
#745
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
Release Note
RELEASE NOTE: FIX Return None instead of throwing an error when a workflow instance is not found