Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helloworld: add terminal to node app for vscode #1125

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

jseguillon
Copy link

Description

When trying to debug helloworld app in vscode I noticed there is no terminal for node app which makes debugging not easy. This PR fixes this issue

Issue reference

#1124

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

@jseguillon jseguillon requested review from a team as code owners January 2, 2025 10:50
@jseguillon jseguillon force-pushed the feat/vscode-terminal-nodeapp branch from 39b6ca1 to 4de6f45 Compare January 2, 2025 10:50
@yaron2 yaron2 added this to the 1.15 milestone Jan 14, 2025
@paulyuk paulyuk changed the base branch from master to release-1.15 January 23, 2025 20:09
Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks a lot for this improvement to the debugging experience.

@paulyuk paulyuk merged commit a54d89d into dapr:release-1.15 Jan 23, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants