-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Dapr Conversation .NET Quickstart #1133
Conversation
Signed-off-by: KentHsu <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @WhitWaldo, a couple of things here:
- can you remove the python sdk crypto quickstart commits since we are cherrypicking those into the release here: Cherry picking 42a99c2 into release branch #1135
- This quickstart is more complex than some of the other ones we were going to do! We were just going to use the basic
echo
dapr component, like you did in your dotnet example: https://github.com/dapr/dotnet-sdk/blob/release-1.15-rc01/examples/AI/ConversationalAI/Program.cs - can you sign off your commits :)
It seems the python commits get added automatically when I target merging with dapr:release-1.15 as I don't have that commit in my fork. Should I target a different branch to merge into? This isn't any more complicated than the version in the .NET examples in that it's just sending a message to the AI endpoint and returning the response. I do think that an example should include best practices (e.g. I can't stand those examples that say don't use passwords in your code, then proceed to do exactly that) - here, this example prefers DI registration over the static builder and the current best practice around .NET logging. I believe my commit is properly signed here. |
Signed-off-by: Whit Waldo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comment
|
||
<PropertyGroup> | ||
<OutputType>Exe</OutputType> | ||
<TargetFramework>net9.0</TargetFramework> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need net 9? I'm thinking we could stay on .NEt 8 because it's LTS, it's on more dev boxes, and that's whats in our test env unless we take action to change the GH actions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also please sync to release-1.15
and attempt to get C# checks to pass?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can stay on .NET 8 here if you'd like. We've got support for .NET 6, 8 and 9 with 1.15 for all clients except Dapr.Workflow (which supports .NET 7, 8 and 9). Version 1.16 will drop .NET 6 and .NET 7.
Signed-off-by: Whit Waldo <[email protected]>
Using the joint collab found in PR #1144 |
Description
Added quickstart featuring the Dapr Conversation API using Anthropic.
Issue reference
N/A - part of 1.15 endgame
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: