-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow to update Dapr. #249
Open
artursouza
wants to merge
6
commits into
dapr:master
Choose a base branch
from
artursouza:new_update_wf
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
675038a
Workflow to update Dapr.
artursouza 4036bcb
Moves compare_versions.py to test-infra
elena-kolevska 9c6e2fb
Adds version update for cli. Signs off commits.
elena-kolevska e98a233
Apply suggestions from code review
elena-kolevska 9c01371
Apply suggestions from code review
elena-kolevska 363ff00
Apply suggestions from code review
elena-kolevska File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
# | ||
# Copyright 2025 The Dapr Authors | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# | ||
# This script parses release version from Git tag and set the parsed version to | ||
# environment variable, REL_VERSION. If the tag is the final version, it sets | ||
# LATEST_RELEASE to true to add 'latest' tag to docker image. | ||
import os | ||
import sys | ||
import semver | ||
|
||
# compare_versions returns True if the comparison is successful. | ||
# It returns False if the versions are invalid. | ||
# The result of the comparison is written to the VERSION_UPDATE_REQUIRED GitHub environment variable. | ||
def compare_versions(new_version, existing_version) -> bool: | ||
try: | ||
new_ver = semver.VersionInfo.parse(new_version) | ||
existing_ver = semver.VersionInfo.parse(existing_version) | ||
except ValueError: | ||
print("Invalid version format") | ||
set_github_env("VERSION_UPDATE_REQUIRED", "false") | ||
return False | ||
|
||
update_required = new_ver > existing_ver | ||
status_message = "New version is greater than existing version." if update_required else "New version is not greater. Skipping update." | ||
print(status_message) | ||
|
||
# Write the update requirement status to GITHUB_ENV | ||
github_env_path = os.getenv("GITHUB_ENV") | ||
if github_env_path: | ||
with open(github_env_path, "a") as github_env: | ||
set_github_env("VERSION_UPDATE_REQUIRED", str(update_required).lower()) | ||
return True | ||
|
||
def set_github_env(name: str, value: str): | ||
github_env_path = os.getenv("GITHUB_ENV") | ||
if github_env_path: | ||
with open(github_env_path, "a") as github_env: | ||
github_env.write(f"{name}={value}\n") | ||
|
||
if len(sys.argv) != 3: | ||
print("Usage: compare_versions.py <new_version> <existing_version>") | ||
sys.exit(1) | ||
|
||
new_version = sys.argv[1] | ||
existing_version = sys.argv[2] | ||
|
||
if compare_versions(new_version, existing_version): | ||
sys.exit(0) | ||
else: | ||
sys.exit(1) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,86 @@ | ||
# | ||
# Copyright 2025 The Dapr Authors | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# | ||
|
||
name: update-cli-version | ||
|
||
on: | ||
pull_request: | ||
paths: | ||
- '.github/workflows/version-update-cli.yml' | ||
- '.github/scripts/compare_versions.py' | ||
|
||
workflow_dispatch: | ||
inputs: | ||
rel_version: | ||
description: 'Dapr release version (examples: 1.9.0-rc.1, 1.9.1)' | ||
required: true | ||
type: string | ||
|
||
jobs: | ||
update-longhauls: | ||
name: Update the dapr version in longhaul tests | ||
runs-on: ubuntu-latest | ||
permissions: | ||
contents: write | ||
env: | ||
LONG_HAUL_REPO: test-infra | ||
REL_VERSION: ${{ github.event.inputs.rel_version || '99.99.99' }} | ||
steps: | ||
- name: Check out code into the Go module directory | ||
uses: actions/checkout@v4 | ||
- name: Checkout the dapr repo | ||
uses: actions/checkout@v4 | ||
with: | ||
repository: dapr/cli | ||
path: .dapr_cli | ||
- name: Install dependencies | ||
run: | | ||
sudo apt-get update | ||
sudo apt-get install pcre2-utils | ||
pip install semver | ||
- name: Parse release version and set REL_VERSION and LATEST_RELEASE | ||
run: python .dapr_cli/.github/scripts/get_release_version.py ${{ github.event_name }} | ||
- name: Compare versions and determine if update of long haul tests is required | ||
id: compare_versions | ||
run: | | ||
REL_VERSION=`echo "${{ env.REL_VERSION }}" | sed -r 's/^[vV]?([0-9].+)$/\1/'` | ||
|
||
# Thanks to https://ihateregex.io/expr/semver/ | ||
SEMVER_REGEX='^(0|[1-9]\d*)\.(0|[1-9]\d*)\.(0|[1-9]\d*)(?:-((?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)(?:\.(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?(?:\+([0-9a-zA-Z-]+(?:\.[0-9a-zA-Z-]+)*))?$' | ||
if [ `echo $REL_VERSION | pcre2grep "$SEMVER_REGEX"` ]; then | ||
echo "$REL_VERSION is a valid semantic version." | ||
else | ||
echo "$REL_VERSION is not a valid semantic version." | ||
exit 1 | ||
fi | ||
echo "REL_VERSION=${REL_VERSION,,}" >>${GITHUB_ENV} | ||
|
||
EXISTING_VERSION=$(cat "config/dapr_runtime.version") | ||
echo "Existing version in longhaul tests: $EXISTING_VERSION" | ||
echo "New version: $REL_VERSION" | ||
python .github/scripts/compare_versions.py "$REL_VERSION" "$EXISTING_VERSION" | ||
- name: Update dapr cli version in the longhaul tests repo | ||
if: env.VERSION_UPDATE_REQUIRED == 'true' | ||
run: | | ||
echo "${REL_VERSION}" > config/dapr_cli.version | ||
- name: Show Diff | ||
run: | | ||
git diff | ||
- name: Commit and push changes | ||
if: github.event_name == 'workflow_dispatch' && env.VERSION_UPDATE_REQUIRED == 'true' | ||
run: | | ||
git config --global user.name "github-actions" | ||
git config --global user.email "[email protected]" | ||
git add config/dapr_cli.version | ||
git commit -s -m "Updates dapr cli version to ${REL_VERSION}" | ||
git push |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,85 @@ | ||||||
# | ||||||
# Copyright 2025 The Dapr Authors | ||||||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||||||
# you may not use this file except in compliance with the License. | ||||||
# You may obtain a copy of the License at | ||||||
# http://www.apache.org/licenses/LICENSE-2.0 | ||||||
# Unless required by applicable law or agreed to in writing, software | ||||||
# distributed under the License is distributed on an "AS IS" BASIS, | ||||||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||||||
# See the License for the specific language governing permissions and | ||||||
# limitations under the License. | ||||||
# | ||||||
|
||||||
name: update-dapr-version | ||||||
|
||||||
on: | ||||||
pull_request: | ||||||
paths: | ||||||
- '.github/workflows/version-update-dapr.yml' | ||||||
- '.github/scripts/compare_versions.py' | ||||||
workflow_dispatch: | ||||||
inputs: | ||||||
rel_version: | ||||||
description: 'Dapr release version (examples: 1.9.0-rc.1, 1.9.1)' | ||||||
required: true | ||||||
type: string | ||||||
|
||||||
jobs: | ||||||
update-longhauls: | ||||||
name: Update the dapr version in longhaul tests | ||||||
runs-on: ubuntu-latest | ||||||
permissions: | ||||||
contents: write | ||||||
env: | ||||||
LONG_HAUL_REPO: test-infra | ||||||
REL_VERSION: ${{ github.event.inputs.rel_version || '99.99.99' }} | ||||||
steps: | ||||||
- name: Check out code into the Go module directory | ||||||
uses: actions/checkout@v4 | ||||||
- name: Checkout the dapr repo | ||||||
uses: actions/checkout@v4 | ||||||
with: | ||||||
repository: dapr/dapr | ||||||
path: .dapr_repo | ||||||
- name: Install dependencies | ||||||
run: | | ||||||
sudo apt-get update | ||||||
sudo apt-get install pcre2-utils | ||||||
pip install semver | ||||||
- name: Parse release version and set REL_VERSION and LATEST_RELEASE | ||||||
run: python .dapr_repo/.github/scripts/get_release_version.py ${{ github.event_name }} | ||||||
Comment on lines
+50
to
+51
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
- name: Compare versions and determine if update of long haul tests is required | ||||||
id: compare_versions | ||||||
run: | | ||||||
REL_VERSION=`echo "${{ env.REL_VERSION }}" | sed -r 's/^[vV]?([0-9].+)$/\1/'` | ||||||
|
||||||
# Thanks to https://ihateregex.io/expr/semver/ | ||||||
SEMVER_REGEX='^(0|[1-9]\d*)\.(0|[1-9]\d*)\.(0|[1-9]\d*)(?:-((?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)(?:\.(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?(?:\+([0-9a-zA-Z-]+(?:\.[0-9a-zA-Z-]+)*))?$' | ||||||
if [ `echo $REL_VERSION | pcre2grep "$SEMVER_REGEX"` ]; then | ||||||
echo "$REL_VERSION is a valid semantic version." | ||||||
else | ||||||
echo "$REL_VERSION is not a valid semantic version." | ||||||
exit 1 | ||||||
fi | ||||||
echo "REL_VERSION=${REL_VERSION,,}" >>${GITHUB_ENV} | ||||||
|
||||||
EXISTING_VERSION=$(cat "config/dapr_runtime.version") | ||||||
echo "Existing version in longhaul tests: $EXISTING_VERSION" | ||||||
echo "New version: $REL_VERSION" | ||||||
python .github/scripts/compare_versions.py "$REL_VERSION" "$EXISTING_VERSION" | ||||||
- name: Update dapr runtime version in the longhaul tests repo | ||||||
if: env.VERSION_UPDATE_REQUIRED == 'true' | ||||||
run: | | ||||||
echo "${REL_VERSION}" > config/dapr_runtime.version | ||||||
- name: Show Diff | ||||||
run: | | ||||||
git diff | ||||||
- name: Commit and push changes | ||||||
if: github.event_name == 'workflow_dispatch' && env.VERSION_UPDATE_REQUIRED == 'true' | ||||||
run: | | ||||||
git config --global user.name "github-actions" | ||||||
git config --global user.email "[email protected]" | ||||||
git add config/dapr_runtime.version | ||||||
git commit -s -m "Updates dapr runtime version to ${REL_VERSION}" | ||||||
git push |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.