Рефакторинг опций сборки и запуска #111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvd170501
commented
Apr 4, 2021
darkkeks
reviewed
Apr 4, 2021
darkkeks
reviewed
Apr 4, 2021
Comment on lines
+36
to
+58
| class BuildOptions: | ||
| def __init__(self, asan=False, verbose=False): | ||
| self.asan = asan | ||
| self.verbose = verbose | ||
|
|
||
|
|
||
| class RunOptions: | ||
| def __init__(self, asan=False, valgrind=False): | ||
| self.asan = asan | ||
| self.valgrind = valgrind | ||
|
|
||
|
|
||
| class TestRunOptions(RunOptions): | ||
| def __init__(self, | ||
| continue_on_error=False, | ||
| ignore_exit_code=False, | ||
| asan=False, | ||
| valgrind=False, | ||
| is_sample=False): | ||
| super().__init__(asan=asan, valgrind=valgrind) | ||
| self.continue_on_error = continue_on_error | ||
| self.ignore_exit_code = ignore_exit_code | ||
| self.is_sample = is_sample |
There was a problem hiding this comment.
Можешь напомнить зачем это разделение?
Пока-что некрасиво получается с TestSource, в который почему-то передаются опции запуска
Хотя он еще и собирает скрипты
There was a problem hiding this comment.
- все эти опции, кроме asan, не нужны в команде
build(и во всех вызовахcompile_solution) - при запуске решения из команды
runнужны только опцииasanиvalgrind
В TestSource сейчас нужен только ignore_exit_code для эталонного решения (возможно, стоит явно передавать его вместо всего объекта TestRunOptions). Опции / таргеты не влияют на сборку скрипта (раньше использовалась только опция для asan)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.