-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: slim down MSYS2 install #738
Conversation
The missing setuptools issue seems to be inside the CodeChecker setup code, |
Also switch coverage to now recommended/default UCRT64 environment
Yeah, i don't understand what is going on there. |
@@ -51,9 +51,6 @@ jobs: | |||
cache: false | |||
msystem: ${{ inputs.msys2-msystem }} | |||
update: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per https://github.com/msys2/setup-msys2?tab=readme-ov-file#update,
that means we don't update the package index either? That seems unfortunate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this was off before my change.
Not really an issue IMHO as you're not interested in testing the latest MSYS2 packages but your code. The msys2-installer and the setup-msys2 action get an update every 3 months or so anyway.
@kmilos thank you. |
Also switch coverage to now recommended/default UCRT64 environment