Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: slim down MSYS2 install #738

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Conversation

kmilos
Copy link
Collaborator

@kmilos kmilos commented Jun 27, 2024

Also switch coverage to now recommended/default UCRT64 environment

@kmilos kmilos requested a review from LebedevRI as a code owner June 27, 2024 11:37
@kmilos kmilos changed the title CI: slim down MSYS2 install CI: slim down MSYS2 install, add missing python-setuptools Jun 27, 2024
@kmilos kmilos force-pushed the kmilos/ci_msys2 branch from 6ef6afd to c5e45ab Compare June 27, 2024 12:09
@kmilos kmilos changed the title CI: slim down MSYS2 install, add missing python-setuptools CI: slim down MSYS2 install Jun 27, 2024
@kmilos
Copy link
Collaborator Author

kmilos commented Jun 27, 2024

The missing setuptools issue seems to be inside the CodeChecker setup code, python3-setuptools-whl is already pulled in previously...

Also switch coverage to now recommended/default UCRT64 environment
@kmilos kmilos force-pushed the kmilos/ci_msys2 branch from c5e45ab to 0de5302 Compare June 27, 2024 14:30
@LebedevRI
Copy link
Member

The missing setuptools issue seems to be inside the CodeChecker setup code, python3-setuptools-whl is already pulled in previously...

Yeah, i don't understand what is going on there.

@@ -51,9 +51,6 @@ jobs:
cache: false
msystem: ${{ inputs.msys2-msystem }}
update: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per https://github.com/msys2/setup-msys2?tab=readme-ov-file#update,
that means we don't update the package index either? That seems unfortunate.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this was off before my change.

Not really an issue IMHO as you're not interested in testing the latest MSYS2 packages but your code. The msys2-installer and the setup-msys2 action get an update every 3 months or so anyway.

@LebedevRI LebedevRI merged commit 06a4e07 into darktable-org:develop Jun 28, 2024
52 of 55 checks passed
@LebedevRI
Copy link
Member

@kmilos thank you.
Does not seem to break CI further than it already is, so i guess this is fine.

@kmilos kmilos deleted the kmilos/ci_msys2 branch June 28, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants